Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a parameter for the repository on Automatic IP Team Review Requests #224

Closed
AngelikaWittek opened this issue Apr 13, 2023 · 4 comments
Closed

Comments

@AngelikaWittek
Copy link

When the dash tool creates IPLab issues, it's not easy to find out which Eclipse project repository it came from. E.g. Eclipse Tractus-X has 36 repositories in its GitHub organization.
If you invoke the tool with the -review option, it would be helpful to have an option for the repository (e.g. the URL), which is also shown in the IPLab issue.

@HannesWell
Copy link
Contributor

This is probably similar to #184 (but probably not a duplication).

@waynebeaton
Copy link
Collaborator

I've extended the tool to include a -repo option from the command line and a dash.repo property from Maven. When specified, the provided value is passed to IP Lab as the "Repository".

As an experiment... when not explicitly specified, the tool tries to figure it out by get trying to identify the Git repository that contains the working directory; when successful, it scans the remotes to try and find one that represents an Eclipse Project repository.

I'm going to experiment with a bit more and push it later tonight or tomorrow.

@HannesWell
Copy link
Contributor

I've extended the tool to include a -repo option from the command line and a dash.repo property from Maven. When specified, the provided value is passed to IP Lab as the "Repository".

That's nice. Could you additionally/alternatively also add a property to add arbitrary 'context' data like requested in #184, which would allow to add a link to the exact PR from which a request was created through the license workflow.
This would simplify for you or the IP team to get in touch with the initiators of the request.

@waynebeaton
Copy link
Collaborator

I can do that, but I'm leaning towards additionally and so will take care of it in a separate commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants