Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

license-tool-plugin 1.0.2 fails to follow redirect to default approved licenses URL #374

Closed
krumts opened this issue Sep 10, 2024 · 4 comments

Comments

@krumts
Copy link

krumts commented Sep 10, 2024

In the Memory Analyzer project we started getting errors like this one, when building the MAT project with maven / tycho.

[ERROR] Failed to execute goal org.eclipse.dash:license-tool-plugin:1.0.2:license-check (license-check) on project parent: 
Execution license-check of goal org.eclipse.dash:license-tool-plugin:1.0.2:license-check failed: 
Cannot invoke "java.util.Map.keySet()" because "this.approvedLicenses" is null -> [Help 1]

In our pom.xml we didn't explicitly configure the approved licenses URL, and were thus using the default "https://www.eclipse.org/legal/licenses.json". Looks like this one was moved one level deeper, under /legal/licenses/licenses.json and the plugin didn't build correctly, although the old URL sends a 302 response to redirect to the new location.

I haven't looked deeper into this. Adding the new URL explicitly resolved the issue for us.
I thought it would be good to report the issue.

Just for reference, this is the issue on the MAT project eclipse-mat/mat#64.

@pzygielo
Copy link

Seems to work fine in current 1.1.0.

@krumts
Copy link
Author

krumts commented Sep 10, 2024

Indeed, it works. I did check for new versions in the repository before opening the ticket and saw the 1.0.3-snapshot, but I have overlooked that there is a 1.1.0 available. Thanks for the help and sorry to bother you with a fixed issue!

@krumts
Copy link
Author

krumts commented Sep 10, 2024

closing the issue, as it was already fixed

@krumts krumts closed this as completed Sep 10, 2024
@waynebeaton
Copy link
Collaborator

We changed the HTTP client configuration to support redirects.

I've also updated the default URL in the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants