Avoid reference to Guava in GitLabSupport #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
HannesWell
force-pushed
the
avoid-guava
branch
from
6044117 to
720e516
Compare
|
I experimented with this myself and saw the test failures. I'll try to investigate that a bit over the weekend. |
I think the reason is just by excluding Guava it is also excluded from the test runtime. But since it is used e.g. in Guice it is in the (test) runtime still required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a transitive dependency but at the same time not a benefit to use it.
In order to avoid future references it's excluded as transitive dependency.Excluding it makes the tests fail and I don't want to over-complicate it with adding Guava back in test-scope.