Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Dependabot manage GitHub Actions versions #431

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

timothyjward
Copy link
Contributor

GitHub actions are versioned and can be deprecated/disabled over time. Letting dependabot manage their updates simplifies keeping things running smoothly.

This relates to (but does not fix) issue #430

GitHub actions are versioned and can be deprecated/disabled over time. Letting dependabot manage their updates simplifies keeping things running smoothly.

Signed-off-by: Tim Ward <[email protected]>
@pzygielo
Copy link

pzygielo commented Mar 3, 2025

Upload action is already updated here

- uses: actions/upload-artifact@v4

But https://github.com/eclipse-osgi-technology/.github/blob/0cc70ab5fd07d1a61a34fcc88fb17c3993f6e14f/.github/workflows/reuse_all_check_eclipse_ip.yml#L13 is pointing to the exact version which will never change and will never use newer upload action.

@waynebeaton waynebeaton requested a review from HannesWell March 3, 2025 16:22
@timothyjward
Copy link
Contributor Author

timothyjward commented Mar 3, 2025

But https://github.com/eclipse-osgi-technology/.github/blob/0cc70ab5fd07d1a61a34fcc88fb17c3993f6e14f/.github/workflows/reuse_all_check_eclipse_ip.yml#L13 is pointing to the exact version which will never change and will never use newer upload action.

The project is attempting to follow security best practice, which is not to point at a "moving target" like @v4 or @main but instead to use the commit id for the latest release tag and then put the tag in the comment. This is why the line reads

eclipse-dash/dash-licenses/.github/workflows/mavenLicenseCheck.yml@90ebdf14dff066293b65b9d3ca99c8fb90d5222b # 1.1.0

Dependabot actually understands this mechanism and will still update the dependencies (and comments) for you, as it did for us in https://github.com/eclipse-osgi-technology/.github/pull/18/files

Upload action is already updated here

It's great that this is already fixed. Is there a release tag we can use which has this fix?

@mbarbero
Copy link

mbarbero commented Mar 3, 2025

FYI, @eclipse-dash/eclipsefdn-security team has a tool to pin all GitHub actions https://github.com/eclipse-csi/octopin

@HannesWell
Copy link
Contributor

FYI, @eclipse-dash/eclipsefdn-security team has a tool to pin all GitHub actions https://github.com/eclipse-csi/octopin

I just pinned the versions that were not yet pinned via #432.

Copy link
Contributor

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you.

@HannesWell HannesWell merged commit 8a0b2a7 into eclipse-dash:master Mar 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants