Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Exclusions Before Creating Review Requests #6

Open
jfaltermeier opened this issue Nov 18, 2024 · 1 comment
Open

Check Exclusions Before Creating Review Requests #6

jfaltermeier opened this issue Nov 18, 2024 · 1 comment

Comments

@jfaltermeier
Copy link
Contributor

When working with npm workspaces, local workspaces are included in the package-lock.json file, which means they are also processed by the license checker. To address getting reviews for internal packages, I added an exclusions file. With this my CI job is green. However, the current setup still tries to open review tickets for the excluded local packages.

It would be helpful if the exclusions were checked before review tickets are created.

Affected project files:

https://github.com/eclipse-theia/theia-cloud/blob/main/node/package-lock.json
https://github.com/eclipse-theia/theia-cloud/blob/main/node/configs/license-check-exclusions.json

Example output:

[main] INFO License information could not be automatically verified for the following content:
[main] INFO 
[main] INFO npm/npmjs/-/landing-page/0.1.0
[main] INFO npm/npmjs/-/testing-page/0.1.0
[main] INFO 
[main] INFO This content is either not correctly mapped by the system, or requires review.
[main] INFO A review is required for npm/npmjs/-/landing-page/0.1.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/17097 .
[main] INFO A review is required for npm/npmjs/-/testing-page/0.1.0.
[main] INFO A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/17098 .
WARN: Command [
  "java",
  "-jar",
  "/home/runner/work/theia-cloud/theia-cloud/node/node_modules/@eclipse-dash/nodejs-wrapper/download/dash-licenses.jar",
  "package-lock.json",
  "-batch",
  50,
  "-timeout",
  200,
  "-summary",
  "/home/runner/work/theia-cloud/theia-cloud/node/license-check-summary.txt",
  "-project",
  "ecd.theia",
  "-review"
] exited with code: 2
INFO: Checking dash-licenses "restricted" results against configured exclusions...
INFO: Some restricted dependencies were found in dash-licenses results, but all were excluded by configuration!
INFO: Found no dependency that requires further investigation. Good job!
INFO: Done.
@waynebeaton
Copy link
Contributor

Related: eclipse-dash/dash-licenses#415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants