From f80fffe9cf62aa14b818614eff1f203dba8fb482 Mon Sep 17 00:00:00 2001 From: rex-schilasky <49162693+rex-schilasky@users.noreply.github.com> Date: Mon, 19 Feb 2024 14:55:22 +0100 Subject: [PATCH 1/2] clang-tidy test --- ecal/core/src/service/ecal_service_client_impl.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ecal/core/src/service/ecal_service_client_impl.cpp b/ecal/core/src/service/ecal_service_client_impl.cpp index ee7076c..cf330d9 100644 --- a/ecal/core/src/service/ecal_service_client_impl.cpp +++ b/ecal/core/src/service/ecal_service_client_impl.cpp @@ -184,6 +184,9 @@ namespace eCAL // blocking call, all responses will be returned in service_response_vec_ bool CServiceClientImpl::Call(const std::string& method_name_, const std::string& request_, int timeout_ms_, ServiceResponseVecT* service_response_vec_) { + // look that clang-tidy ! + service_response_vec_->clear(); + if(service_response_vec_ == nullptr) return false; service_response_vec_->clear(); From ea43a39e03fe3335991f7bbf17298217891438f3 Mon Sep 17 00:00:00 2001 From: rex-schilasky <49162693+rex-schilasky@users.noreply.github.com> Date: Mon, 19 Feb 2024 17:41:13 +0100 Subject: [PATCH 2/2] test 2 --- .github/workflows/clang-tidy-review.yml | 10 +++++----- ecal/core/src/service/ecal_service_client_impl.cpp | 3 +++ 2 files changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/workflows/clang-tidy-review.yml b/.github/workflows/clang-tidy-review.yml index 541fec1..cbc5488 100644 --- a/.github/workflows/clang-tidy-review.yml +++ b/.github/workflows/clang-tidy-review.yml @@ -51,16 +51,16 @@ jobs: -DECAL_CORE_PUBLISHER=ON \ -DECAL_CORE_SUBSCRIBER=ON \ -DECAL_CORE_SERVICE=ON \ - -DECAL_CORE_TIMEPLUGIONN=ON \ - -DECAL_CORE_TRANSPORT_UDPON=ON \ - -DECAL_CORE_TRANSPORT_TCPON=ON \ - -DECAL_CORE_TRANSPORT_SHMON=ON \ + -DECAL_CORE_TIMEPLUGIN=ON \ + -DECAL_CORE_TRANSPORT_UDP=ON \ + -DECAL_CORE_TRANSPORT_TCP=ON \ + -DECAL_CORE_TRANSPORT_SHM=ON \ -DECAL_CORE_NPCAP_SUPPORT=OFF \ -DBUILD_SHARED_LIBS=ON \ -DCMAKE_BUILD_TYPE=Release \ -DCMAKE_INSTALL_SYSCONFDIR=/etc \ -DCMAKE_INSTALL_PREFIX=/usr \ - -DCMAKE_INSTALL_LOCALSTATEDONIR=/var \ + -DCMAKE_INSTALL_LOCALSTATEDIR=/var \ -DCMAKE_INSTALL_LIBDIR=lib/x86_FF4-linux-gnu cmake --build _build diff --git a/ecal/core/src/service/ecal_service_client_impl.cpp b/ecal/core/src/service/ecal_service_client_impl.cpp index cf330d9..5f3363b 100644 --- a/ecal/core/src/service/ecal_service_client_impl.cpp +++ b/ecal/core/src/service/ecal_service_client_impl.cpp @@ -186,6 +186,9 @@ namespace eCAL { // look that clang-tidy ! service_response_vec_->clear(); + int i; + char* p; + *p = 'X'; if(service_response_vec_ == nullptr) return false; service_response_vec_->clear();