Python API for measurement.__iter__() is broken

[danieldube]

Problem Description

When I run the following Python code, I would expect to iterate over the measurement channels. Instead, a TypeError is raised.

    measurement = Measurement(str(measurement_path))
    for channel in measurement:
        for message in channel:
            print(message)

Traceback (most recent call last):
  File "/home/uidg4302/projects/cls_dspace/python/src/tools/analyze_acc.py", line 18, in <module>
    main()
  File "/home/uidg4302/python/cls_venv/lib/python3.8/site-packages/click/core.py", line 1157, in __call__
    return self.main(*args, **kwargs)
  File "/home/uidg4302/python/cls_venv/lib/python3.8/site-packages/click/core.py", line 1078, in main
    rv = self.invoke(ctx)
  File "/home/uidg4302/python/cls_venv/lib/python3.8/site-packages/click/core.py", line 1434, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/home/uidg4302/python/cls_venv/lib/python3.8/site-packages/click/core.py", line 783, in invoke
    return __callback(*args, **kwargs)
  File "/home/uidg4302/projects/cls_dspace/python/src/tools/analyze_acc.py", line 12, in main
    for channel in measurement:
  File "/home/uidg4302/python/cls_venv/lib/python3.8/site-packages/ecal/measurement/measurement.py", line 215, in __iter__
    return Measurement.Iterator(self)
TypeError: __init__() missing 1 required positional argument: 'channel_type'

I think the Measurement.__init__() has a bug and is not using the constructor for Measurement.Iterator correctly.

Please see:

ecal/lang/python/ecalhdf5/ecal/measurement/measurement.py

Line 215 in fe84826

return Measurement.Iterator(self)

and:

ecal/lang/python/ecalhdf5/ecal/measurement/measurement.py

Line 190 in fe84826

def __init__(self, measurement, channel_type):

How to reproduce

See above how to reproduce the issue.

How did you get eCAL?

Download from Release Page

Environment

-eCAL: 5.12.6
-OS: Ubuntu 20.04
-Python: 3.8
-Compiler and CMake: not applicable

eCAL System Information

No response

[KerstinKeller]

Thanks for reporting. This issue was introduced with fe84826 and will be fixed ASAP.

[KerstinKeller]

• PR master: [python] Fix iterating over measurement which was broken by fe84826 #1750
• PR 5.13: [CP #1750 > support/v5.13] [python] Fix iterating over measurement which was broken by fe84826 #1751
• PR 5.12: [CP #1750 > support/v5.12] [python] Fix iterating over measurement which was broken by fe84826 #1752

[danieldube]

Thanks a lot for the fast reply, Kerstin!