Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Oauth2ClientImpl should read expires_in #4130

Closed
wolf4ood opened this issue Apr 22, 2024 · 0 comments · Fixed by #4131
Closed

Oauth2ClientImpl should read expires_in #4130

wolf4ood opened this issue Apr 22, 2024 · 0 comments · Fixed by #4131
Assignees
@wolf4ood
Labels
feature_request New feature request, awaiting triage

Comments

@wolf4ood
Copy link
Contributor

wolf4ood commented Apr 22, 2024 •
edited
Loading

Feature Request

Currently when using Oauth2Client#requestToken it returns a TokenRepresentation which contains the token from the access_token response from the Oauth2 server.

TokenRepresentation contains also the property expires_in but it's not currently mapped in the default impl Oauth2ClientImpl.

Since we are doing this change it probably make sense also to put in the TokenResponse#additional field the other returned parameters from the OAuth2 call, which can be for example scope ,refresh_token
@wolf4ood wolf4ood added the feature_request New feature request, awaiting triage label Apr 22, 2024
@wolf4ood wolf4ood self-assigned this Apr 22, 2024
@github-actions github-actions bot added the triage all new issues awaiting classification label Apr 22, 2024
@wolf4ood wolf4ood removed the triage all new issues awaiting classification label Apr 22, 2024
@wolf4ood wolf4ood mentioned this issue Apr 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wolf4ood wolf4ood

Labels
feature_request New feature request, awaiting triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: map expires_in in TokenRepresentation wolf4ood/DataSpaceConnector
1 participant
@wolf4ood