Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Collection as a Policy Evaluation Expression #4679

Open
bmg13 opened this issue Dec 17, 2024 · 3 comments
Open

Add Collection as a Policy Evaluation Expression #4679

bmg13 opened this issue Dec 17, 2024 · 3 comments
Labels
feature_request New feature request, awaiting triage stale Open for x days with no activity

Comments

@bmg13
Copy link
Contributor

bmg13 commented Dec 17, 2024

Feature Request

ℹ️ This issue is a result of the feedback obtained described in here.

Which Areas Would Be Affected?

This Feature proposes the possibility of having Collections as rightOperand in Policies.
As an example, for creating a Policy with a constraint to match if the groups a BPNL is assigned are allowed to fetch the respective catalog, the rightOperand could be something similar to the following

"constraint": 
{
	"leftOperand": "tx:BusinessPartnerGroup",
	"operator": "isAllOf",
	"rightOperand": ["some-group-1", "some-group-2"]
}

Instead of having to contain a comma-separated String as an only option (for this scenario).

Why Is the Feature Desired?

To allow to have a more broad use of different types, specially Collection.

Solution Proposal

Create a new Expression implementation to include a Collection as well.

@bmg13 bmg13 added bug_report Suspected bugs, awaiting triage triage all new issues awaiting classification labels Dec 17, 2024
Copy link

Thanks for your contribution 🔥 We will take a look asap 🚀

@bmg13 bmg13 added feature_request New feature request, awaiting triage and removed bug_report Suspected bugs, awaiting triage labels Dec 17, 2024
@bmg13 bmg13 changed the title Fix BPNL Group Validation for a Policy with a Collection as a rightOperand #1674 Add Collection as a Policy Evaluation Expression Dec 17, 2024
@jimmarino
Copy link
Contributor

This is not something trivial to support, given the ambiguities associated with Json-Ld. See #4525. It would require significant time to investigate. The current string-based approach can support the requirement, so I don't thing this will get very high priority.

@ndr-brt ndr-brt removed the triage all new issues awaiting classification label Dec 18, 2024
Copy link

github-actions bot commented Jan 2, 2025

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale Open for x days with no activity label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature_request New feature request, awaiting triage stale Open for x days with no activity
Projects
None yet
Development

No branches or pull requests

3 participants