data plane restart flow throws NPE

[ndr-brt]

Bug Report

When a data-plane tries to restart a PULL transfer (without destinationAddress) it throws NPE.

Expected Behavior

Not to throw it

Observed Behavior

2025-01-15T08:42:50.4508424Z     �[0;31mjava.lang.NullPointerException: Cannot invoke "org.eclipse.edc.spi.types.domain.DataAddress.getType()" because the return value of "org.eclipse.edc.spi.types.domain.transfer.DataFlowStartMessage.getDestinationDataAddress()" is null
2025-01-15T08:42:50.4510356Z     	at org.eclipse.edc.connector.dataplane.framework.pipeline.PipelineServiceImpl.lambda$getSinkFactory$4(PipelineServiceImpl.java:173)
2025-01-15T08:42:50.4511506Z     	at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:178)
2025-01-15T08:42:50.4512232Z     	at java.base/java.util.ArrayList$ArrayListSpliterator.tryAdvance(ArrayList.java:1602)
2025-01-15T08:42:50.4513050Z     	at java.base/java.util.stream.ReferencePipeline.forEachWithCancel(ReferencePipeline.java:129)
2025-01-15T08:42:50.4513886Z     	at java.base/java.util.stream.AbstractPipeline.copyIntoWithCancel(AbstractPipeline.java:527)
2025-01-15T08:42:50.4514782Z     	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:513)
2025-01-15T08:42:50.4515530Z     	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
2025-01-15T08:42:50.4516244Z     	at java.base/java.util.stream.FindOps$FindOp.evaluateSequential(FindOps.java:150)
2025-01-15T08:42:50.4517049Z     	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
2025-01-15T08:42:50.4517612Z     	at java.base/java.util.stream.ReferencePipeline.findFirst(ReferencePipeline.java:647)
2025-01-15T08:42:50.4518360Z     	at org.eclipse.edc.connector.dataplane.framework.pipeline.PipelineServiceImpl.getSinkFactory(PipelineServiceImpl.java:174)
2025-01-15T08:42:50.4519262Z     	at org.eclipse.edc.connector.dataplane.framework.pipeline.PipelineServiceImpl.canHandle(PipelineServiceImpl.java:58)
2025-01-15T08:42:50.4520425Z     	at org.eclipse.edc.connector.dataplane.framework.registry.TransferServiceRegistryImpl.lambda$resolveTransferService$0(TransferServiceRegistryImpl.java:45)
2025-01-15T08:42:50.4521296Z     	at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:178)
2025-01-15T08:42:50.4521864Z     	at java.base/java.util.Spliterators$IteratorSpliterator.tryAdvance(Spliterators.java:1856)
2025-01-15T08:42:50.4522466Z     	at java.base/java.util.stream.ReferencePipeline.forEachWithCancel(ReferencePipeline.java:129)
2025-01-15T08:42:50.4523086Z     	at java.base/java.util.stream.AbstractPipeline.copyIntoWithCancel(AbstractPipeline.java:527)
2025-01-15T08:42:50.4523657Z     	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:513)
2025-01-15T08:42:50.4524324Z     	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
2025-01-15T08:42:50.4524863Z     	at java.base/java.util.stream.FindOps$FindOp.evaluateSequential(FindOps.java:150)
2025-01-15T08:42:50.4525366Z     	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
2025-01-15T08:42:50.4525892Z     	at java.base/java.util.stream.ReferencePipeline.findFirst(ReferencePipeline.java:647)
2025-01-15T08:42:50.4526727Z     	at org.eclipse.edc.connector.dataplane.framework.registry.TransferServiceSelectionStrategy.lambda$selectFirst$0(TransferServiceSelectionStrategy.java:46)
2025-01-15T08:42:50.4527859Z     	at org.eclipse.edc.connector.dataplane.framework.registry.TransferServiceRegistryImpl.resolveTransferService(TransferServiceRegistryImpl.java:46)
2025-01-15T08:42:50.4528873Z     	at org.eclipse.edc.connector.dataplane.framework.manager.DataPlaneManagerImpl.processReceived(DataPlaneManagerImpl.java:246)
2025-01-15T08:42:50.4529756Z     	at org.eclipse.edc.connector.dataplane.framework.manager.DataPlaneManagerImpl.restartFlow(DataPlaneManagerImpl.java:177)
2025-01-15T08:42:50.4530505Z     	at org.eclipse.edc.spi.telemetry.Telemetry.lambda$contextPropagationMiddleware$0(Telemetry.java:73)
2025-01-15T08:42:50.4531106Z     	at org.eclipse.edc.statemachine.ProcessorImpl.lambda$process$1(ProcessorImpl.java:55)
2025-01-15T08:42:50.4531649Z     	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
2025-01-15T08:42:50.4532193Z     	at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
2025-01-15T08:42:50.4532735Z     	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
2025-01-15T08:42:50.4533276Z     	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
2025-01-15T08:42:50.4533826Z     	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
2025-01-15T08:42:50.4534421Z     	at java.base/java.util.stream.ReduceOps$5.evaluateSequential(ReduceOps.java:258)
2025-01-15T08:42:50.4534900Z     	at java.base/java.util.stream.ReduceOps$5.evaluateSequential(ReduceOps.java:248)
2025-01-15T08:42:50.4535390Z     	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
2025-01-15T08:42:50.4535920Z     	at java.base/java.util.stream.ReferencePipeline.count(ReferencePipeline.java:709)
2025-01-15T08:42:50.4536431Z     	at org.eclipse.edc.statemachine.ProcessorImpl.process(ProcessorImpl.java:62)
2025-01-15T08:42:50.4536949Z     	at java.base/java.util.stream.ReferencePipeline$5$1.accept(ReferencePipeline.java:231)
2025-01-15T08:42:50.4537802Z     	at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625)
2025-01-15T08:42:50.4538347Z     	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
2025-01-15T08:42:50.4538886Z     	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
2025-01-15T08:42:50.4539437Z     	at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:921)
2025-01-15T08:42:50.4539963Z     	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
2025-01-15T08:42:50.4540570Z     	at java.base/java.util.stream.LongPipeline.reduce(LongPipeline.java:498)
2025-01-15T08:42:50.4541014Z     	at java.base/java.util.stream.LongPipeline.sum(LongPipeline.java:456)
2025-01-15T08:42:50.4541547Z     	at org.eclipse.edc.statemachine.StateMachineManager.performLogic(StateMachineManager.java:110)
2025-01-15T08:42:50.4542187Z     	at org.eclipse.edc.statemachine.StateMachineManager.lambda$loop$2(StateMachineManager.java:101)
2025-01-15T08:42:50.4542767Z     	at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539)
2025-01-15T08:42:50.4543230Z     	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
2025-01-15T08:42:50.4543860Z     	at java.base/java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304)
2025-01-15T08:42:50.4544697Z     	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
2025-01-15T08:42:50.4545282Z     	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
2025-01-15T08:42:50.4545729Z     	at java.base/java.lang.Thread.run(Thread.java:840)

Context Information

current main branch

Detailed Description

If applicable, add screenshots and logs to help explain your problem.

Possible Implementation

You already know the root cause of the erroneous state and how to fix it? Feel free to share your thoughts.

[ndr-brt]

It was a false negative, not really a bug