Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor HAshicorpHealthService #4751

Open
paullatzelsperger opened this issue Jan 22, 2025 · 0 comments
Open

Refactor HAshicorpHealthService #4751

paullatzelsperger opened this issue Jan 22, 2025 · 0 comments
Assignees
@paullatzelsperger
Labels
refactoring Cleaning up code and dependencies triage all new issues awaiting classification

Comments

@paullatzelsperger
Copy link
Member

Feature Request

The HAshicorpHealthCheckService currently does too many things: sending a heartbeat to HCV and refreshing tokens.

This needs to be refactored.

Which Areas Would Be Affected?

hashicorp vault extension

Why Is the Feature Desired?

separation of concerns, cleanliness of the code base

Solution Proposal

If possible, provide a (brief!) solution proposal.
@paullatzelsperger paullatzelsperger added the refactoring Cleaning up code and dependencies label Jan 22, 2025
@paullatzelsperger paullatzelsperger self-assigned this Jan 22, 2025
@github-actions github-actions bot added the triage all new issues awaiting classification label Jan 22, 2025
@paullatzelsperger paullatzelsperger mentioned this issue Jan 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paullatzelsperger paullatzelsperger

Labels
refactoring Cleaning up code and dependencies triage all new issues awaiting classification
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@paullatzelsperger