Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: remove specific AuthenticationRequestFilter in APIs #4753

Closed
wolf4ood opened this issue Jan 22, 2025 · 0 comments · Fixed by #4758
Closed

Refactor: remove specific AuthenticationRequestFilter in APIs #4753

wolf4ood opened this issue Jan 22, 2025 · 0 comments · Fixed by #4758
Labels
breaking-change Will require manual intervention for version update refactoring Cleaning up code and dependencies

Comments

@wolf4ood
Copy link
Contributor

Feature Request

Currently for each API that needs auth we register in the web context a AuthenticationRequestFilter with a specific target (e.g. management-api). After this clean up #4726 we removed the hardcoded way of configuring authentication in favor of the auth-configuration extension. We don't need that custom AuthenticationRequestFilter registration for each API context, since the API configuration already provide that in a more consistent way. For example

with this configuration

web.http.management.auth.type=tokenbased
web.http.management.auth.key.alias=vaultAlias

The auth-configuration extension will associate the token based authentication to the management API context and will also register
the AuthenticationRequestFilter.

@wolf4ood wolf4ood added the refactoring Cleaning up code and dependencies label Jan 22, 2025
@github-actions github-actions bot added the triage all new issues awaiting classification label Jan 22, 2025
@wolf4ood wolf4ood added breaking-change Will require manual intervention for version update and removed triage all new issues awaiting classification labels Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Will require manual intervention for version update refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant