fix "The value of the parameter is not used"

org.eclipse.jdt.debug.tests/tests/org/eclipse/jdt/debug/tests/refactoring/PushDownFieldUnitTests.java

@@ -34,7 +34,7 @@ public void testWatchPoint() throws Exception {
 			//create Breakpoint to test
 			createWatchpoint("a.b.c.Movee", "anInt", true, true);
 			//refactor
-			Refactoring ref = setupRefactor("Movee","anInt","src","a.b.c","Movee.java");
+			Refactoring ref = setupRefactor("Movee", "src", "a.b.c", "Movee.java");
 			performRefactor(ref);
 			//test breakpoints
 			IBreakpoint[] breakPoints = getBreakpointManager().getBreakpoints();
@@ -52,7 +52,7 @@ public void testWatchPoint() throws Exception {
 
 /////////////////////////////////////////
 
-	private Refactoring setupRefactor(String parentClassName, String className, String root, String targetPackageName, String cuName) throws Exception {
+private Refactoring setupRefactor(String parentClassName, String root, String targetPackageName, String cuName) throws Exception {
 
 		IJavaProject javaProject = get14Project();
 		IType parentClas= getCompilationUnit(javaProject, root, targetPackageName, cuName).getType(parentClassName);

org.eclipse.jdt.debug.tests/tests/org/eclipse/jdt/debug/tests/ui/presentation/ModelPresentationTests.java

@@ -272,7 +272,7 @@ public void testSimpleArrayValueText() throws Exception {
 		try {
 			String sig = Signature.createTypeSignature("org.test.MyClass", false);
 			TestIJavaType type = new TestIJavaType("barfoo", sig);
-			TestIJavaArrayValue value = new TestIJavaArrayValue(type, "org.test.MyArrayClass[]", null, "org.test.MyClass", "My Array", 3);
+			TestIJavaArrayValue value = new TestIJavaArrayValue(type, "org.test.MyArrayClass[]", null, "org.test.MyClass", "My Array");
 			value.setValues(new IJavaValue[] {
 					new TestIJavaValue(type, "I", null, "org.test.MyArrayClass", "Array Value 1")
 			});

org.eclipse.jdt.debug.tests/tests/org/eclipse/jdt/debug/tests/ui/presentation/TestIJavaArrayValue.java

@@ -24,10 +24,7 @@ public class TestIJavaArrayValue extends TestIJavaObjectValue implements IJavaAr
 	int size = 0;
 	IJavaValue[] values;
 
-	/**
-	 * Constructor
-	 */
-	public TestIJavaArrayValue(IJavaType type, String sig, String gsig,	String rtname, String vstring, int size) {
+	TestIJavaArrayValue(IJavaType type, String sig, String gsig, String rtname, String vstring) {
 		super(type, sig, gsig, rtname, vstring);
 	}
 

org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/JDIModelPresentation.java

@@ -115,7 +115,7 @@
  * Determines how to display java elements, including labels, images and editors.
  * @see IDebugModelPresentation
  */
 @SuppressWarnings("deprecation")
 public class JDIModelPresentation extends LabelProvider implements IDebugModelPresentationExtension, IColorProvider {
 
 	/**
@@ -704,10 +704,10 @@
 
 		try {
 			if (item instanceof JDIReferenceListVariable) {
-				return getReferencesImage(item);
+				return getReferencesImage();
 			}
 			if (item instanceof JDIReferenceListEntryVariable){
-				return getReferenceImage(item);
+				return getReferenceImage();
 			}
 			if (item instanceof IJavaVariable) {
 				return getVariableImage((IAdaptable) item);
@@ -938,7 +938,7 @@
 	 *
 	 * @return image associated with reference variables
 	 */
-	protected Image getReferencesImage(Object element){
+	private Image getReferencesImage() {
 		return JavaDebugImages.get(JavaDebugImages.IMG_ELCL_ALL_REFERENCES);
 	}
 
@@ -948,7 +948,7 @@
 	 *
 	 * @return image associated with reference variables
 	 */
-	protected Image getReferenceImage(Object element){
+	private Image getReferenceImage() {
 		return JavaDebugImages.get(JavaDebugImages.IMG_OBJS_REFERENCE);
 	}
 

org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/launcher/WorkspaceOperationRunner.java

@@ -63,16 +63,16 @@ public IProgressMonitor getProgressMonitor() {
 	@Override
 	public void run(boolean fork, boolean cancelable, IRunnableWithProgress runnable) throws InvocationTargetException, InterruptedException {
 		if (runnable instanceof ISchedulingRuleProvider) {
-			run(fork, cancelable, runnable, ((ISchedulingRuleProvider)runnable).getSchedulingRule());
+			run(runnable, ((ISchedulingRuleProvider) runnable).getSchedulingRule());
 		} else {
-			run(fork, cancelable, runnable, ResourcesPlugin.getWorkspace().getRoot());
+			run(runnable, ResourcesPlugin.getWorkspace().getRoot());
 		}
 	}
 
 	/**
 	 * Runs a new {@link WorkspaceModifyDelegatingOperation}
 	 */
-	public void run(boolean fork, boolean cancelable, IRunnableWithProgress runnable, ISchedulingRule schedulingRule) throws InvocationTargetException, InterruptedException {
+	private void run(IRunnableWithProgress runnable, ISchedulingRule schedulingRule) throws InvocationTargetException, InterruptedException {
 		WorkspaceModifyDelegatingOperation operation= new WorkspaceModifyDelegatingOperation(runnable, schedulingRule);
 		operation.run(getProgressMonitor());
 	}

org.eclipse.jdt.debug.ui/ui/org/eclipse/jdt/internal/debug/ui/propertypages/JavaBreakpointAdvancedPage.java

@@ -26,7 +26,7 @@
 import org.eclipse.ui.PlatformUI;
 import org.eclipse.ui.dialogs.PropertyPage;
 
-public class JavaBreakpointAdvancedPage extends PropertyPage {
+public abstract class JavaBreakpointAdvancedPage extends PropertyPage {
 
 	ThreadFilterEditor fThreadFilterEditor;
 	InstanceFilterEditor fInstanceFilterEditor;
@@ -82,9 +82,7 @@ public void createInstanceFilterEditor(Composite parent) {
 	/**
 	 * Allow subclasses to create type-specific editors.
 	 */
-	protected void createTypeSpecificEditors(Composite parent) {
-		// Do nothing.
-	}
+	abstract void createTypeSpecificEditors(Composite parent);
 
 	protected void createThreadFilterEditor(Composite parent) {
 		fThreadFilterEditor = new ThreadFilterEditor(parent, this);

org.eclipse.jdt.debug/jdi/org/eclipse/jdi/internal/event/EventImpl.java

@@ -174,11 +174,10 @@ public static EventImpl read(MirrorImpl target, DataInputStream dataInStream)
 			result = ThreadStartEventImpl.read(target, requestID, dataInStream);
 			break;
 		case VMDeathEventImpl.EVENT_KIND:
-			result = VMDeathEventImpl.read(target, requestID, dataInStream);
+			result = VMDeathEventImpl.read(target, requestID);
 			break;
 		case VMDisconnectEventImpl.EVENT_KIND:
-			result = VMDisconnectEventImpl
-					.read(target, requestID, dataInStream);
+			result = VMDisconnectEventImpl.read(target, requestID);
 			break;
 		case VMStartEventImpl.EVENT_KIND:
 			result = VMStartEventImpl.read(target, requestID, dataInStream);
@@ -190,8 +189,9 @@ public static EventImpl read(MirrorImpl target, DataInputStream dataInStream)
 		}
 
 		// Find and store original request.
-		if (!requestID.isNull())
+		if (!requestID.isNull()) {
 			result.fRequest = target.virtualMachineImpl().eventRequestManagerImpl().findRequest(result);
+		}
 
 		return result;
 	}
@@ -209,16 +209,18 @@ public EventRequest request() {
 	 * Retrieves constant mappings.
 	 */
 	public static void getConstantMaps() {
-		if (fEventKindMap != null)
+		if (fEventKindMap != null) {
 			return;
+		}
 
 		java.lang.reflect.Field[] fields = EventImpl.class.getDeclaredFields();
 		fEventKindMap = new HashMap<>();
 		for (Field field : fields) {
 			if ((field.getModifiers() & java.lang.reflect.Modifier.PUBLIC) == 0
 					|| (field.getModifiers() & java.lang.reflect.Modifier.STATIC) == 0
-					|| (field.getModifiers() & java.lang.reflect.Modifier.FINAL) == 0)
+					|| (field.getModifiers() & java.lang.reflect.Modifier.FINAL) == 0) {
 				continue;
+			}
 
 			try {
 				String name = field.getName();

org.eclipse.jdt.debug/jdi/org/eclipse/jdi/internal/event/VMDeathEventImpl.java

@@ -13,8 +13,6 @@
  *******************************************************************************/
 package org.eclipse.jdi.internal.event;
 
-import java.io.DataInputStream;
-
 import org.eclipse.jdi.internal.MirrorImpl;
 import org.eclipse.jdi.internal.VirtualMachineImpl;
 import org.eclipse.jdi.internal.request.RequestID;
@@ -40,8 +38,7 @@ public VMDeathEventImpl(VirtualMachineImpl vmImpl, RequestID requestID) {
 	 * Creates, reads and returns new EventImpl, of which requestID has
 	 *         already been read.
 	 */
-	public static VMDeathEventImpl read(MirrorImpl target, RequestID requestID,
-			DataInputStream dataInStream) {
+	static VMDeathEventImpl read(MirrorImpl target, RequestID requestID) {
 		VirtualMachineImpl vmImpl = target.virtualMachineImpl();
 		VMDeathEventImpl event = new VMDeathEventImpl(vmImpl, requestID);
 		return event;

org.eclipse.jdt.debug/jdi/org/eclipse/jdi/internal/event/VMDisconnectEventImpl.java

@@ -13,8 +13,6 @@
  *******************************************************************************/
 package org.eclipse.jdi.internal.event;
 
-import java.io.DataInputStream;
-
 import org.eclipse.jdi.internal.MirrorImpl;
 import org.eclipse.jdi.internal.VirtualMachineImpl;
 import org.eclipse.jdi.internal.request.RequestID;
@@ -42,8 +40,7 @@ public VMDisconnectEventImpl(VirtualMachineImpl vmImpl, RequestID requestID) {
 	 *         already been read.
 	 * @return the new event
 	 */
-	public static VMDisconnectEventImpl read(MirrorImpl target,
-			RequestID requestID, DataInputStream dataInStream) {
+	static VMDisconnectEventImpl read(MirrorImpl target, RequestID requestID) {
 		VirtualMachineImpl vmImpl = target.virtualMachineImpl();
 		VMDisconnectEventImpl event = new VMDisconnectEventImpl(vmImpl,
 				requestID);

org.eclipse.jdt.debug/model/org/eclipse/jdt/internal/debug/core/hcr/JavaHotCodeReplaceManager.java

@@ -663,7 +663,7 @@ private void redefineTypesJDK(JDIDebugTarget target, List<IResource> resources,
 						JDIDebugHCRMessages.JavaHotCodeReplaceManager_hcr_failed,
 						exception);
 			}
-			target.reinstallBreakpointsIn(resources, qualifiedNames);
+			target.reinstallBreakpointsIn(qualifiedNames);
 		} else {
 			target.notSupported(JDIDebugHCRMessages.JavaHotCodeReplaceManager_does_not_support_hcr);
 		}

org.eclipse.jdt.debug/model/org/eclipse/jdt/internal/debug/core/model/JDIDebugTarget.java

@@ -1020,7 +1020,7 @@ public boolean hasHCROccurred() {
 	/**
 	 * Reinstall all breakpoints installed in the given resources
 	 */
-	public void reinstallBreakpointsIn(List<IResource> resources, List<String> classNames) {
+	public void reinstallBreakpointsIn(List<String> classNames) {
 		List<IBreakpoint> breakpoints = getBreakpoints();
 		IJavaBreakpoint[] copy = new IJavaBreakpoint[breakpoints.size()];
 		breakpoints.toArray(copy);