Remove repetitive code from JDIModelPresentation #575
+127
−160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and using smart instanceof to remove clutter
|
My only concern with this PR is making methods/members private and the possibility that this might break something in the SDK (not checked). Do you think you can drop that part so we can land it in without worries ? |
This PR changes "internal" packages only. So it should not break anything else. If it does we can revert. |
|
My request was exactly so a revert of the whole change can be skipped as the breakage is more likely to come from public to private change. |
|
I've reverted method privatization. What needs to be built in order to check that those methods are not used outside this repository? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and using smart instanceof to remove clutter
What it does
Eliminate the very verbose and repetitive image handling code - that looks up based on JavaDebugImages or IDebugUIConstants constants the actual ImageDescriptors and Image objects.
And eliminate a lot of redundant casts with using ' instanceof' patterns.
How to test
Run it, it shouldn't change any visible behaviour.
Author checklist