From 406166997cfa5ae056ac5958f86aec113ddee127 Mon Sep 17 00:00:00 2001 From: Jinbo Wang Date: Wed, 15 Nov 2023 13:29:31 +0800 Subject: [PATCH] Log an error message for the out-of-sync case --- .../internal/handlers/BaseDocumentLifeCycleHandler.java | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/BaseDocumentLifeCycleHandler.java b/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/BaseDocumentLifeCycleHandler.java index 379db6215e..00a64a7368 100644 --- a/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/BaseDocumentLifeCycleHandler.java +++ b/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/BaseDocumentLifeCycleHandler.java @@ -60,7 +60,6 @@ import org.eclipse.jdt.internal.core.PackageFragment; import org.eclipse.jdt.ls.core.internal.DocumentAdapter; import org.eclipse.jdt.ls.core.internal.JDTUtils; -import org.eclipse.jdt.ls.core.internal.JavaClientConnection; import org.eclipse.jdt.ls.core.internal.JavaLanguageServerPlugin; import org.eclipse.jdt.ls.core.internal.JobHelpers; import org.eclipse.jdt.ls.core.internal.MovingAverage; @@ -69,7 +68,6 @@ import org.eclipse.jdt.ls.core.internal.corrections.DiagnosticsHelper; import org.eclipse.jdt.ls.core.internal.managers.InvisibleProjectImporter; import org.eclipse.jdt.ls.core.internal.managers.ProjectsManager; -import org.eclipse.jdt.ls.core.internal.managers.TelemetryEvent; import org.eclipse.jdt.ls.core.internal.preferences.PreferenceManager; import org.eclipse.jface.text.BadLocationException; import org.eclipse.jface.text.IDocument; @@ -448,11 +446,7 @@ public ICompilationUnit handleChanged(DidChangeTextDocumentParams params) { * buffer has been modified by an unexpected program and has become * inconsistent with the client document. */ - JavaClientConnection connection = JavaLanguageServerPlugin.getInstance().getClientConnection(); - if (connection != null) { - connection.telemetryEvent(new TelemetryEvent("java.ls.error.documentOutOfSync", null)); - } - JavaLanguageServerPlugin.logInfo("Editor contents out-of-sync for unit: " + unit.getElementName()); + JavaLanguageServerPlugin.logError("Document on language server is out-of-sync: " + unit.getElementName()); } List contentChanges = params.getContentChanges(); for (TextDocumentContentChangeEvent changeEvent : contentChanges) {