Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Malwarebytes thinks JDT LS is executing an exploit #1142

Closed
vasiltabakov opened this issue Aug 4, 2019 · 4 comments
Closed

Malwarebytes thinks JDT LS is executing an exploit #1142

vasiltabakov opened this issue Aug 4, 2019 · 4 comments

Comments

@vasiltabakov
Copy link

About a week ago I've noticed Malwarebytes complaining about some Java exploit while I was running the JDT LS but thought it's something different (as other Java code ran alongside with the LS does have similar executions).

While investigating a LS NPE today I found this error line in the log:

[04/08/2019 16:48:28.731] [LOG]    
window:  
Aug 4, 2019 4:48:28 PM 
Parent process stopped running, forcing server exit

Tracked down the message to ParentProcessWatcher.java where the cmd is created and executed.

Here's what Malwarebytes shows:
image

I've managed to adjust Malwarebytes but wonder if this can be avoided from within JDT LS or whether this should be mentioned in the Wiki.

If this helps here's some more log after the event:

[04/08/2019 16:48:28.731] [LOG]    window:  Aug 4, 2019 4:48:28 PM Parent process stopped running, forcing server exit
[04/08/2019 16:48:28.732] [LOG]    window:  Aug 4, 2019 4:48:28 PM Shutdown received... waking up main thread
[04/08/2019 16:48:28.741] [LOG]    window:  Aug 4, 2019 4:48:28 PM class org.eclipse.jdt.ls.core.internal.JavaLanguageServerPlugin is stopping:
[04/08/2019 16:48:29.277] [LOG]    window:  Aug 4, 2019 4:48:29 PM The workspace will exit with unsaved changes in this session.
@snjeza
Copy link
Contributor

snjeza commented Aug 4, 2019

You can try the following property:

"java.jdt.ls.vmargs": "-DwatchParentProcess=false -noverify -Xmx2G -XX:+UseG1GC -XX:+UseStringDeduplication"

@vasiltabakov
Copy link
Author

Thanks, I'm using your suggested config now, much better also because the IDE handles shutting down the LS before it quits.

@snjeza
Copy link
Contributor

snjeza commented Aug 5, 2019

See also #991

@rgrunber
Copy link
Contributor

Closing as this seems to have been resolved. The language server shuts down when the client sends a shutdown, followed by an exit. In some cases, we've observed this may not happen, and so we have the ParentProcessWatcher to ensure subsequent restarts/failed shutdowns of the language server do not leave the processes idling. As mentioned though, the option can be configured if it is unwanted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants