Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring in support for mapstruct #2651

Open
gayanper opened this issue May 12, 2023 · 6 comments
Open

Bring in support for mapstruct #2651

gayanper opened this issue May 12, 2023 · 6 comments

Comments

@gayanper
Copy link
Contributor

The IDE support at https://github.com/mapstruct/mapstruct-eclipse/tree/master would be nice if we can bring in the jdtls as we have done with Lombok.

@gayanper
Copy link
Contributor Author

@jdneo @snjeza @testforstephen @rgrunber WDYT?

@gayanper
Copy link
Contributor Author

gayanper commented May 13, 2023

I just looked into original eclipse plugin and its fairly simple plugin, but it depends on JDT UI components for quickfixes and completions.

Since the plugin is not updated during last 7 years, We have few options

  • Check with the author if they would like to receive some updates into the plugin so that we can make the mapstruct plugin logic reusable in jdt.ls by decoupling them from JDT UI.

  • Implement the mapstruct support from scratch in jdt.ls

I would prefer the first option, either on the original repo or a fork under the eclipse, microsoft or redhat org.

@jdneo
Copy link
Contributor

jdneo commented May 14, 2023

Check with the author if they would like to receive some updates into the plugin so that we can make the mapstruct plugin logic reusable in jdt.ls by decoupling them from JDT UI.

Will it be a plugin of JDT.LS( like https://github.com/microsoft/vscode-lombok), or directly enabled in JDT.LS?

@gayanper
Copy link
Contributor Author

Check with the author if they would like to receive some updates into the plugin so that we can make the mapstruct plugin logic reusable in jdt.ls by decoupling them from JDT UI.

Will it be a plugin of JDT.LS( like https://github.com/microsoft/vscode-lombok), or directly enabled in JDT.LS?

I'm thinking adding it as a plugin of JDT.LS for providing content assist and quick fixes. But i would like to start with content assist first.

Ofcourse we need to think about annotation processing as well. That could be done as we have supported lombok may be. WDYT ?

@jdneo
Copy link
Contributor

jdneo commented May 15, 2023

I'm thinking adding it as a plugin of JDT.LS

Yes, it looks good to me.

@gayanper
Copy link
Contributor Author

I think we need this feature support #2653 before we can continue on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants