Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Find references" misses reference in known .class files #2846

Closed
mickaelistria opened this issue Sep 13, 2023 · 4 comments
Closed

"Find references" misses reference in known .class files #2846

mickaelistria opened this issue Sep 13, 2023 · 4 comments

Comments

@mickaelistria
Copy link
Contributor

Using "Find References" in JDT-UI allows to resolve references to a type, even if the references are in .class files known as part of the class/module path. This can often be convenient when one navigate complex code and doesn't have all the dependencies as source in their workspace.
JDT-LS seems only to be able to return consumers that are part of the currently imported project .java file. This is often too limiting.
JDT-LS should list all known consumers of a type in the scope of a project or classpath.

@rgrunber
Copy link
Contributor

image

I see that you're setting classFileContentsSupport so it should work.

JDT-LS Communication
[Trace - 13:17:00] Sending request 'textDocument/references - (64)'.
Params: {
    "textDocument": {
        "uri": "file:///home/rgrunber/git/eclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/contentassist/SnippetCompletionProposal.java"
    },
    "position": {
        "line": 613,
        "character": 30
    },
    "context": {
        "includeDeclaration": true
    }
}
...
...
[Trace - 13:17:01] Received response 'textDocument/references - (64)' in 875ms.
Result: [
    {
        "uri": "jdt://contents/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar/org.eclipse.jdt.core/ICompilationUnit.class?=org.eclipse.jdt.ls.core/%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar=/javadoc_location=/jar:file:%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.doc.isv_3.14.2100.v20230901-1632.jar%5C!%5C/reference%5C/api=/%3Corg.eclipse.jdt.core(ICompilationUnit.class",
        "range": {
            "start": {
                "line": 472,
                "character": 8
            },
            "end": {
                "line": 472,
                "character": 16
            }
        }
    },
    {
        "uri": "jdt://contents/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar/org.eclipse.jdt.core.dom.rewrite/ImportRewrite.class?=org.eclipse.jdt.ls.core/%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar=/javadoc_location=/jar:file:%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.doc.isv_3.14.2100.v20230901-1632.jar%5C!%5C/reference%5C/api=/%3Corg.eclipse.jdt.core.dom.rewrite(ImportRewrite.class",
        "range": {
            "start": {
                "line": 637,
                "character": 43
            },
            "end": {
                "line": 637,
                "character": 53
            }
        }
    },
    {
        "uri": "jdt://contents/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar/org.eclipse.jdt.internal.codeassist/SelectionEngine.class?=org.eclipse.jdt.ls.core/%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar=/javadoc_location=/jar:file:%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.doc.isv_3.14.2100.v20230901-1632.jar%5C!%5C/reference%5C/api=/%3Corg.eclipse.jdt.internal.codeassist(SelectionEngine.class",
        "range": {
            "start": {
                "line": 1590,
                "character": 32
            },
            "end": {
                "line": 1590,
                "character": 42
            }
        }
    },
    {
        "uri": "jdt://contents/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar/org.eclipse.jdt.internal.codeassist.impl/Engine.class?=org.eclipse.jdt.ls.core/%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar=/javadoc_location=/jar:file:%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.doc.isv_3.14.2100.v20230901-1632.jar%5C!%5C/reference%5C/api=/%3Corg.eclipse.jdt.internal.codeassist.impl(Engine.class",
        "range": {
            "start": {
                "line": 108,
                "character": 64
            },
            "end": {
                "line": 108,
                "character": 74
            }
        }
    },
    {
        "uri": "jdt://contents/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar/org.eclipse.jdt.internal.core/CompilationUnit.class?=org.eclipse.jdt.ls.core/%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar=/javadoc_location=/jar:file:%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.doc.isv_3.14.2100.v20230901-1632.jar%5C!%5C/reference%5C/api=/%3Corg.eclipse.jdt.internal.core(CompilationUnit.class",
        "range": {
            "start": {
                "line": 640,
                "character": 24
            },
            "end": {
                "line": 640,
                "character": 34
            }
        }
    },
    {
        "uri": "jdt://contents/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar/org.eclipse.jdt.internal.core/CompilationUnit.class?=org.eclipse.jdt.ls.core/%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar=/javadoc_location=/jar:file:%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.doc.isv_3.14.2100.v20230901-1632.jar%5C!%5C/reference%5C/api=/%3Corg.eclipse.jdt.internal.core(CompilationUnit.class",
        "range": {
            "start": {
                "line": 970,
                "character": 25
            },
            "end": {
                "line": 970,
                "character": 35
            }
        }
    },
    {
        "uri": "jdt://contents/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar/org.eclipse.jdt.internal.core/CopyResourceElementsOperation.class?=org.eclipse.jdt.ls.core/%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar=/javadoc_location=/jar:file:%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.doc.isv_3.14.2100.v20230901-1632.jar%5C!%5C/reference%5C/api=/%3Corg.eclipse.jdt.internal.core(CopyResourceElementsOperation.class",
        "range": {
            "start": {
                "line": 803,
                "character": 23
            },
            "end": {
                "line": 803,
                "character": 33
            }
        }
    },
    {
        "uri": "jdt://contents/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar/org.eclipse.jdt.internal.core/CreateImportOperation.class?=org.eclipse.jdt.ls.core/%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar=/javadoc_location=/jar:file:%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.doc.isv_3.14.2100.v20230901-1632.jar%5C!%5C/reference%5C/api=/%3Corg.eclipse.jdt.internal.core(CreateImportOperation.class",
        "range": {
            "start": {
                "line": 146,
                "character": 21
            },
            "end": {
                "line": 146,
                "character": 31
            }
        }
    },
    {
        "uri": "jdt://contents/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar/org.eclipse.jdt.internal.core/CreatePackageDeclarationOperation.class?=org.eclipse.jdt.ls.core/%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar=/javadoc_location=/jar:file:%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.doc.isv_3.14.2100.v20230901-1632.jar%5C!%5C/reference%5C/api=/%3Corg.eclipse.jdt.internal.core(CreatePackageDeclarationOperation.class",
        "range": {
            "start": {
                "line": 108,
                "character": 21
            },
            "end": {
                "line": 108,
                "character": 31
            }
        }
    },
    {
        "uri": "jdt://contents/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar/org.eclipse.jdt.internal.core/NameLookup.class?=org.eclipse.jdt.ls.core/%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar=/javadoc_location=/jar:file:%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.doc.isv_3.14.2100.v20230901-1632.jar%5C!%5C/reference%5C/api=/%3Corg.eclipse.jdt.internal.core(NameLookup.class",
        "range": {
            "start": {
                "line": 285,
                "character": 33
            },
            "end": {
                "line": 285,
                "character": 43
            }
        }
    },
    {
        "uri": "jdt://contents/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar/org.eclipse.jdt.internal.core/NameLookup.class?=org.eclipse.jdt.ls.core/%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar=/javadoc_location=/jar:file:%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.doc.isv_3.14.2100.v20230901-1632.jar%5C!%5C/reference%5C/api=/%3Corg.eclipse.jdt.internal.core(NameLookup.class",
        "range": {
            "start": {
                "line": 875,
                "character": 18
            },
            "end": {
                "line": 875,
                "character": 28
            }
        }
    },
    {
        "uri": "jdt://contents/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar/org.eclipse.jdt.internal.core/NameLookup.class?=org.eclipse.jdt.ls.core/%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar=/javadoc_location=/jar:file:%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.doc.isv_3.14.2100.v20230901-1632.jar%5C!%5C/reference%5C/api=/%3Corg.eclipse.jdt.internal.core(NameLookup.class",
        "range": {
            "start": {
                "line": 1581,
                "character": 47
            },
            "end": {
                "line": 1581,
                "character": 57
            }
        }
    },
    {
        "uri": "jdt://contents/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar/org.eclipse.jdt.internal.core/SearchableEnvironment.class?=org.eclipse.jdt.ls.core/%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar=/javadoc_location=/jar:file:%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.doc.isv_3.14.2100.v20230901-1632.jar%5C!%5C/reference%5C/api=/%3Corg.eclipse.jdt.internal.core(SearchableEnvironment.class",
        "range": {
            "start": {
                "line": 207,
                "character": 65
            },
            "end": {
                "line": 207,
                "character": 75
            }
        }
    },
    {
        "uri": "jdt://contents/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar/org.eclipse.jdt.internal.core/SelectionRequestor.class?=org.eclipse.jdt.ls.core/%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar=/javadoc_location=/jar:file:%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.doc.isv_3.14.2100.v20230901-1632.jar%5C!%5C/reference%5C/api=/%3Corg.eclipse.jdt.internal.core(SelectionRequestor.class",
        "range": {
            "start": {
                "line": 1068,
                "character": 25
            },
            "end": {
                "line": 1068,
                "character": 35
            }
        }
    },
    {
        "uri": "jdt://contents/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar/org.eclipse.jdt.internal.core.hierarchy/ChangeCollector.class?=org.eclipse.jdt.ls.core/%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar=/javadoc_location=/jar:file:%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.doc.isv_3.14.2100.v20230901-1632.jar%5C!%5C/reference%5C/api=/%3Corg.eclipse.jdt.internal.core.hierarchy(ChangeCollector.class",
        "range": {
            "start": {
                "line": 339,
                "character": 48
            },
            "end": {
                "line": 339,
                "character": 58
            }
        }
    },
    {
        "uri": "jdt://contents/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar/org.eclipse.jdt.internal.core.hierarchy/HierarchyResolver.class?=org.eclipse.jdt.ls.core/%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.core_3.35.0.v20230814-1356.jar=/javadoc_location=/jar:file:%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.doc.isv_3.14.2100.v20230901-1632.jar%5C!%5C/reference%5C/api=/%3Corg.eclipse.jdt.internal.core.hierarchy(HierarchyResolver.class",
        "range": {
            "start": {
                "line": 736,
                "character": 33
            },
            "end": {
                "line": 736,
                "character": 43
            }
        }
    },
    {
        "uri": "jdt://contents/org.eclipse.jdt.apt.core_3.8.100.v20230804-1454.jar/org.eclipse.jdt.apt.core.internal.declaration/PackageDeclarationImpl.class?=org.eclipse.jdt.ls.core/%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.apt.core_3.8.100.v20230804-1454.jar=/javadoc_location=/jar:file:%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.doc.isv_3.14.2100.v20230901-1632.jar%5C!%5C/reference%5C/api=/%3Corg.eclipse.jdt.apt.core.internal.declaration(PackageDeclarationImpl.class",
        "range": {
            "start": {
                "line": 251,
                "character": 32
            },
            "end": {
                "line": 251,
                "character": 42
            }
        }
    },
    {
        "uri": "jdt://contents/org.eclipse.jdt.core.manipulation_1.19.100.v20230811-2104.jar/org.eclipse.jdt.internal.corext.refactoring/Checks.class?=org.eclipse.jdt.ls.core/%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.core.manipulation_1.19.100.v20230811-2104.jar=/javadoc_location=/jar:file:%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.doc.isv_3.14.2100.v20230901-1632.jar%5C!%5C/reference%5C/api=/%3Corg.eclipse.jdt.internal.corext.refactoring(Checks.class",
        "range": {
            "start": {
                "line": 284,
                "character": 41
            },
            "end": {
                "line": 284,
                "character": 51
            }
        }
    },
    {
        "uri": "jdt://contents/org.eclipse.jdt.core.manipulation_1.19.100.v20230811-2104.jar/org.eclipse.jdt.internal.corext.refactoring.code/InlineMethodRefactoring.class?=org.eclipse.jdt.ls.core/%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.core.manipulation_1.19.100.v20230811-2104.jar=/javadoc_location=/jar:file:%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.doc.isv_3.14.2100.v20230901-1632.jar%5C!%5C/reference%5C/api=/%3Corg.eclipse.jdt.internal.corext.refactoring.code(InlineMethodRefactoring.class",
        "range": {
            "start": {
                "line": 328,
                "character": 27
            },
            "end": {
                "line": 328,
                "character": 37
            }
        }
    },
    {
        "uri": "jdt://contents/org.eclipse.jdt.core.manipulation_1.19.100.v20230811-2104.jar/org.eclipse.jdt.internal.corext.refactoring.util/JavaElementUtil.class?=org.eclipse.jdt.ls.core/%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.core.manipulation_1.19.100.v20230811-2104.jar=/javadoc_location=/jar:file:%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.doc.isv_3.14.2100.v20230901-1632.jar%5C!%5C/reference%5C/api=/%3Corg.eclipse.jdt.internal.corext.refactoring.util(JavaElementUtil.class",
        "range": {
            "start": {
                "line": 98,
                "character": 23
            },
            "end": {
                "line": 98,
                "character": 33
            }
        }
    },
    {
        "uri": "jdt://contents/org.eclipse.jdt.core.manipulation_1.19.100.v20230811-2104.jar/org.eclipse.jdt.internal.corext.refactoring.util/JavaElementUtil.class?=org.eclipse.jdt.ls.core/%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.core.manipulation_1.19.100.v20230811-2104.jar=/javadoc_location=/jar:file:%5C/home%5C/rgrunber%5C/.config%5C/Code%5C/User%5C/workspaceStorage%5C/843e4ec647bdfd7265e8fa58e4757ee9%5C/redhat.java%5C/jdt_ws%5C/.metadata%5C/.plugins%5C/org.eclipse.pde.core%5C/.bundle_pool%5C/plugins%5C/org.eclipse.jdt.doc.isv_3.14.2100.v20230901-1632.jar%5C!%5C/reference%5C/api=/%3Corg.eclipse.jdt.internal.corext.refactoring.util(JavaElementUtil.class",
        "range": {
            "start": {
                "line": 129,
                "character": 35
            },
            "end": {
                "line": 129,
                "character": 45
            }
        }
    },
    {
        "uri": "file:///home/rgrunber/git/eclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/contentassist/SnippetCompletionProposal.java",
        "range": {
            "start": {
                "line": 613,
                "character": 26
            },
            "end": {
                "line": 613,
                "character": 36
            }
        }
    },
    {
        "uri": "file:///home/rgrunber/git/eclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/corext/refactoring/rename/RenameCompilationUnitProcessor.java",
        "range": {
            "start": {
                "line": 405,
                "character": 33
            },
            "end": {
                "line": 405,
                "character": 43
            }
        }
    },
    {
        "uri": "file:///home/rgrunber/git/eclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/corext/refactoring/rename/RenamePackageProcessor.java",
        "range": {
            "start": {
                "line": 600,
                "character": 34
            },
            "end": {
                "line": 600,
                "character": 44
            }
        }
    },
    {
        "uri": "file:///home/rgrunber/git/eclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/corext/refactoring/rename/RenamePackageProcessor.java",
        "range": {
            "start": {
                "line": 623,
                "character": 37
            },
            "end": {
                "line": 623,
                "character": 47
            }
        }
    },
    {
        "uri": "file:///home/rgrunber/git/eclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/corext/refactoring/rename/RenamePackageProcessor.java",
        "range": {
            "start": {
                "line": 995,
                "character": 68
            },
            "end": {
                "line": 995,
                "character": 78
            }
        }
    },
    {
        "uri": "file:///home/rgrunber/git/eclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/corext/refactoring/rename/RenameTypeProcessor.java",
        "range": {
            "start": {
                "line": 1006,
                "character": 32
            },
            "end": {
                "line": 1006,
                "character": 42
            }
        }
    },
    {
        "uri": "file:///home/rgrunber/git/eclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/corext/refactoring/reorg/MoveCuUpdateCreator.java",
        "range": {
            "start": {
                "line": 238,
                "character": 38
            },
            "end": {
                "line": 238,
                "character": 48
            }
        }
    },
    {
        "uri": "file:///home/rgrunber/git/eclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/corext/refactoring/reorg/MoveCuUpdateCreator.java",
        "range": {
            "start": {
                "line": 318,
                "character": 77
            },
            "end": {
                "line": 318,
                "character": 87
            }
        }
    },
    {
        "uri": "file:///home/rgrunber/git/eclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/corext/refactoring/reorg/MoveModifications.java",
        "range": {
            "start": {
                "line": 122,
                "character": 22
            },
            "end": {
                "line": 122,
                "character": 32
            }
        }
    },
    {
        "uri": "file:///home/rgrunber/git/eclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/corext/refactoring/reorg/ReorgPolicyFactory.java",
        "range": {
            "start": {
                "line": 184,
                "character": 76
            },
            "end": {
                "line": 184,
                "character": 86
            }
        }
    },
    {
        "uri": "file:///home/rgrunber/git/eclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/corext/refactoring/reorg/ReorgPolicyFactory.java",
        "range": {
            "start": {
                "line": 1417,
                "character": 23
            },
            "end": {
                "line": 1417,
                "character": 33
            }
        }
    },
    {
        "uri": "file:///home/rgrunber/git/eclipse.jdt.ls/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/corext/refactoring/reorg/ReorgPolicyFactory.java",
        "range": {
            "start": {
                "line": 2364,
                "character": 77
            },
            "end": {
                "line": 2364,
                "character": 87
            }
        }
    }
]

You can see both file:///... (source) & jdt:///... (class) entries in the result.

@mickaelistria
Copy link
Contributor Author

Indeed, I can see it works now (and remember it has worked many times). I don't recall the particular example that drove me to open this issue, it could be a corner-case or a usage issue; but there is indeed no point in keeping this ticket open.

@rgrunber
Copy link
Contributor

FWIW, I do occasionally see tickets opened against strange behaviour for call hierarchy, or references. In some cases there may be incorrect behaviour. However, it does generally work.

@mickaelistria
Copy link
Contributor Author

Opened redhat-developer/eclipseide-jdtls#99 on client side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants