-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable licensecheck #2966
Enable licensecheck #2966
Conversation
All seem to pass but : It comes from https://www.eclipse.org/downloads/download.php?file=/buildship/updates/e423/snapshots/3.x/3.1.7.v20221108-1729-s/plugins/org.gradle.toolingapi_7.4.2.v20220712-0930-s.jar so it should be permitted. |
/request-license-review |
18e5a9b
to
af6e30a
Compare
/request-license-review |
I'm not seeing anything at https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/?sort=created_date&state=all&first_page_size=20 . |
This can only work after the workflow has been submitted to the default branch of the repo. After this PE has been merged, you can still trigger a license review by adding that comment to this PR. |
@rgrunber now we need /request-license-review from committer |
/request-license-review |
Indeed, but I can't tell why this happens. In general it works:
Maybe this repo has stricter permissions? |
I just added the required permissions explicitly to the license-check-workflow:
You probably have to specify the permissions similary in the caller workflow, if this repo does not by default grant all-write permisions, just like I did it for m2e: |
A fix as explained in eclipse-jdtls#2966 (comment)
A fix as explained in #2966 (comment)
No description provided.