Fix the document out-of-sync due to multi threads changing the current workingcopy buffer #2969
Conversation
|
test this please |
|
The license check failed for p2/orbit/p2.eclipse.plugin/org.gradle.toolingapi/7.4.2.v20220712-0930-s, this is same as #2966 (comment) |
|
@testforstephen Would you please add comment with content /request-license-review here ? We are trying to get the licencheck fixed and as per https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/3969 I would like to know whether it will work for a PR from committer's repo branch . |
This comment was marked as duplicate.
This comment was marked as duplicate.
1 similar comment
|
/request-license-review |
Commented. Seems nothing happened. Updated: I received email notification that it triggered a new action with the comment, that still failed. See https://github.com/eclipse-jdtls/eclipse.jdt.ls/actions/runs/6944174606/job/18890746473. However, if you clicked the validation link in this PR view, it was still linked to the old action job, that's weird. |
License review requests: After all reviews have concluded, re-run the license-vetting check from the Github Actions web-interface to update its status. Workflow run (with attached summary files): |
|
Any reason this is still a draft ? Based on #2955 (comment) I think we could actually remove some more duplicated code. |
We plan to merge this PR after this month's release. We want to let the trace out first and allow us to measure its impact on the stable release. |
testforstephen
force-pushed
the
jinbo_outOfSync
branch
from
80c47a7 to
4051462
Compare
|
@rgrunber The duplicated code is removed. |
Fixes #2955, see that issue for the detailed explanation on the root cause.