Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

o.e.equinox.launcher.${ws}.${os}.${arch} fragments may be safe to remove from runtime #3051

Open
rgrunber opened this issue Feb 9, 2024 · 0 comments
Labels
build/infra dependencies Pull requests that update a dependency file

Comments

@rgrunber
Copy link
Contributor

rgrunber commented Feb 9, 2024

As a result of redhat-developer/vscode-java#3484 & eclipse-equinox/equinox#508 , I began to wonder whether these bundles, whose primary contribution is a native library (.so/.dll accessible through JNI) is even needed in JDT-LS.

Looking at https://github.com/eclipse-equinox/equinox/blob/a61555a7cd126803700a47e8c6fbacc9c595f9df/bundles/org.eclipse.equinox.launcher/src/org/eclipse/equinox/launcher/JNIBridge.java#L28-L44 makes me extremely optimistic that all these fragments can be removed.

Removing these would eliminate 5 bundles (~0.5MB), and because every native library needs to be copied out of its jar fragment and placed on the filesystem (cached) to be accessed, it would slightly (~200KB) reduce the size of the Eclipse configuration location.

@rgrunber rgrunber added build/infra dependencies Pull requests that update a dependency file labels Feb 9, 2024
@rgrunber rgrunber changed the title org.eclipse.equinox.launcher.${ws}.${os}.${arch} fragments may be safe to remove from runtime o.e.equinox.launcher.${ws}.${os}.${arch} fragments may be safe to remove from runtime Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build/infra dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

1 participant