You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The OleInitialize/OleUninitialize seem related to support for Windows WPF graphical subsystem, which also doesn't affect us
Removing these would eliminate 5 bundles (~0.5MB), and because every native library needs to be copied out of its jar fragment and placed on the filesystem (cached) to be accessed, it would slightly (~200KB) reduce the size of the Eclipse configuration location.
The text was updated successfully, but these errors were encountered:
rgrunber
changed the title
org.eclipse.equinox.launcher.${ws}.${os}.${arch} fragments may be safe to remove from runtime
o.e.equinox.launcher.${ws}.${os}.${arch} fragments may be safe to remove from runtime
Feb 13, 2024
As a result of redhat-developer/vscode-java#3484 & eclipse-equinox/equinox#508 , I began to wonder whether these bundles, whose primary contribution is a native library (
.so
/.dll
accessible through JNI) is even needed in JDT-LS.Looking at https://github.com/eclipse-equinox/equinox/blob/a61555a7cd126803700a47e8c6fbacc9c595f9df/bundles/org.eclipse.equinox.launcher/src/org/eclipse/equinox/launcher/JNIBridge.java#L28-L44 makes me extremely optimistic that all these fragments can be removed.
-showSplash
. There's also-noSplash
if we really needed to be sure._set_launcher_info
also requires-showSplash
_set_exit_data
requires a system property we never set in our runtime_get_os_recommended_folder
is used only on macOS but it requires-protect
which we don't supply.. so that's not needed.OleInitialize
/OleUninitialize
seem related to support for Windows WPF graphical subsystem, which also doesn't affect usRemoving these would eliminate 5 bundles (~0.5MB), and because every native library needs to be copied out of its jar fragment and placed on the filesystem (cached) to be accessed, it would slightly (~200KB) reduce the size of the Eclipse configuration location.
The text was updated successfully, but these errors were encountered: