Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature help may include same-named methods that are not on the declaring class hierarchy #3094

Open
rgrunber opened this issue Mar 7, 2024 · 0 comments

Comments

@rgrunber
Copy link
Contributor

rgrunber commented Mar 7, 2024

See #3052 (comment)

Background
The main issue that #3052 solved was that when signature help is done on some method invocation, the overloads (if any) are only discovered for the inherited classes of the declaring class that declares the method. This completely misses the subclasses. Trying to find the subclasses is expensive, which is probably why we never did it. That's why we got rid of hierarchy logic.

However, now we don't have a way to catch same-named methods that don't have anything to do with the hierarchy. If you look at the example, it's a pretty rare since the casting in the example is needed to reproduce the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant