You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With javac parser/resolver, the DOM is often more complete and fault-tolerant. This leads to some cases where SignatureHelpHandler gets into SignatureHelpUtils.getSignatureHelpFromASTNode successfully while ECJ doesn't. That is fine per se.
However, the SignatureHelp activeSignature/activeParameter are not set for this case. An example a piece of code like foo("", ); (with a missing arg) could lead to unset activeSignature/activeParameter with Javac (and maybe even with ECJ too).
This is perceived as an issue for the SignatureHelpHandlerTests.
If we want success with Javac for those tests, then either we need the tests to be changed, or -probably better-, we need SignatureHelpUtils.getSignatureHelpFromASTNode to set activeSignature/activeParameter for this case.
The text was updated successfully, but these errors were encountered:
With javac parser/resolver, the DOM is often more complete and fault-tolerant. This leads to some cases where SignatureHelpHandler gets into
SignatureHelpUtils.getSignatureHelpFromASTNode
successfully while ECJ doesn't. That is fine per se.However, the SignatureHelp activeSignature/activeParameter are not set for this case. An example a piece of code like
foo("", );
(with a missing arg) could lead to unset activeSignature/activeParameter with Javac (and maybe even with ECJ too).This is perceived as an issue for the SignatureHelpHandlerTests.
If we want success with Javac for those tests, then either we need the tests to be changed, or -probably better-, we need
SignatureHelpUtils.getSignatureHelpFromASTNode
to set activeSignature/activeParameter for this case.The text was updated successfully, but these errors were encountered: