Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SignatureHelp activeSignature/activeParameter not set for DOM nodes with #3237

Closed
mickaelistria opened this issue Aug 11, 2024 · 1 comment
Closed

Comments

@mickaelistria
Copy link
Contributor

With javac parser/resolver, the DOM is often more complete and fault-tolerant. This leads to some cases where SignatureHelpHandler gets into SignatureHelpUtils.getSignatureHelpFromASTNode successfully while ECJ doesn't. That is fine per se.
However, the SignatureHelp activeSignature/activeParameter are not set for this case. An example a piece of code like foo("", ); (with a missing arg) could lead to unset activeSignature/activeParameter with Javac (and maybe even with ECJ too).
This is perceived as an issue for the SignatureHelpHandlerTests.

If we want success with Javac for those tests, then either we need the tests to be changed, or -probably better-, we need SignatureHelpUtils.getSignatureHelpFromASTNode to set activeSignature/activeParameter for this case.

@mickaelistria
Copy link
Contributor Author

No issue with JDT-LS, this was caused by the recovered node for missing parameters not properly setting source ranges in JavacConverter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant