Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The milestone 1.9.0 does not contain the fix for the regex at line #3304

Closed
onlinemax opened this issue Oct 23, 2024 · 2 comments
Closed

The milestone 1.9.0 does not contain the fix for the regex at line #3304

onlinemax opened this issue Oct 23, 2024 · 2 comments
Labels

Comments

@onlinemax
Copy link

When downloading the milestone 1.9.0 tar.gz file (which is the latest) at the url: (https://download.eclipse.org/jdtls/milestones/1.9.0/).
The bin/jtdls.py does not contained the updated regex:
matches = re.finditer(r"(?<=version\s\")(?P<major>\d+)(\.\d+\.\d+(_\d+)?)?", out)
and still has the old one:
matches = re.finditer(r"(?P<major>\d+)\.\d+\.\d+", out)

Making the same error described in the issue of: https://github.com/eclipse-jdtls/eclipse.jdt.ls/issues/2060

@rgrunber
Copy link
Contributor

I just had a look at https://github.com/eclipse-jdtls/eclipse.jdt.ls/blob/master/CHANGELOG.md#1110-may-5th-2022 , which would list eactly which issues/changes were made for which milestone. Looks like it was fixed in 1.11.0. 1.9.0 was released on March 3rd 2022, but the issue wasn't reported until mid-April 2022.

@rgrunber
Copy link
Contributor

Closing for now as I think the timelines are pretty accurate as to what happened. Usually, it's best to keep on a newer version of JDT-LS as there are many improvements from each release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants