Enhance initialization of gradle projects

[snjeza]

Fixes

• Slow workspace initialization and reference search in large Gradle monorep redhat-developer/vscode-java#3904
• extension has problem activating most of the time redhat-developer/vscode-java#3901

[rgrunber]

Looked back to #1874 , as I wanted to be sure we're not undoing the reason we moved it here to begin with. I guess the condition holds, We're starting the bundles even more before language server initialization. It's in a job that gets scheduled when the JDT-LS bundle is started.

Should this be reproducible before this PR ? If I insert a breakpoint right at JavaCore.initializeAfterLoad(monitor); in the initializeAfterLoad job and one at InitHandler.handleInitializationOptions(..) and attempt to make sure the initializeAfterLoad call runs first, I'm not seeing a dead lock after proceeding with the thread that runs in the InitHandler. Am I missing something ?

[snjeza]

test this please

[rgrunber]

Should this be reproducible before this PR ? If I insert a breakpoint right at JavaCore.initializeAfterLoad(monitor); in the initializeAfterLoad job and one at InitHandler.handleInitializationOptions(..) and attempt to make sure the initializeAfterLoad call runs first, I'm not seeing a dead lock after proceeding with the thread that runs in the InitHandler. Am I missing something ?

@snjeza let me know about steps to reproduce if there exist some consistent way

[snjeza]

let me know about steps to reproduce if there exist some consistent way

There isn't a consistent way. You can try the following:

• remove 3ebcd0e#diff-9a0082e77ac0fd278079256456f80d3413a62a98a886f9659cef0b6b29e3e0b9R196 lines 196-200. You can move them to InitHandler.handleInitializationOptions()
• import spring-petclinic
• wait for the build to finish
• reload the window

VS Code will freeze sometimes.
It is more straightforward to reproduce if you create a vsix.

[snjeza]

test this please

[snjeza]

test this please

[snjeza]

The related PR - #3361

[rgrunber]

Overall, I think this fixes the issue! I would just add a message in the body of the commit :

- Move Maven/Gradle bundle activation from initialization to JDT-LS startup
- Synchronize annotation processing configuration only if necessary

[snjeza]

Overall, I think this fixes the issue! I would just add a message in the body of the commit :

I have added it.