This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17
Mock service leveraging kuksa client lib #88
Merged
SebastianSchildt
merged 11 commits into
eclipse-kuksa:main
from
boschglobal:feature/mock_with_kuksa_client_lib
Aug 22, 2023
Merged
Mock service leveraging kuksa client lib #88
SebastianSchildt
merged 11 commits into
eclipse-kuksa:main
from
boschglobal:feature/mock_with_kuksa_client_lib
Aug 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… added to the datapoints
Needed because it needs pypi package thats pre released
7b973c2
to
4786b0f
Compare
4786b0f
to
0992991
Compare
Closed
@doosuu can you check whether this works/seems reasonable |
doosuu
reviewed
Aug 9, 2023
doosuu
reviewed
Aug 9, 2023
doosuu
reviewed
Aug 9, 2023
doosuu
reviewed
Aug 9, 2023
doosuu
reviewed
Aug 9, 2023
doosuu
reviewed
Aug 9, 2023
doosuu
reviewed
Aug 9, 2023
doosuu
reviewed
Aug 9, 2023
doosuu
reviewed
Aug 9, 2023
doosuu
reviewed
Aug 9, 2023
doosuu
reviewed
Aug 9, 2023
doosuu
reviewed
Aug 9, 2023
doosuu
reviewed
Aug 9, 2023
doosuu
reviewed
Aug 9, 2023
doosuu
reviewed
Aug 9, 2023
doosuu
reviewed
Aug 9, 2023
doosuu
reviewed
Aug 9, 2023
doosuu
suggested changes
Aug 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rework findings.
CI failing due to reformatting of docs with pre-commit hooks. |
doosuu
reviewed
Aug 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look at my latest comments
LGTM |
SebastianSchildt
approved these changes
Aug 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR leverages kuksa-client lib instead of pure grpc and protobuf files. It fixes too the EventTrigger on values.