DocumentBuild.waitUntil doesn't resolve if document exists and is already in desired state

[colin-grant-work]

Langium version: 3.3.0
Package name: langium

Steps To Reproduce

1. Add a document to the document cache.
2. Ask the document builder to build that document.
3. Wait until the document has finished building.
4. Call .waitUntil with the desired state.
5. The promise will not resolve if the document is already in the desired state.

The current check requires that the document be in a more advanced state than the requested state:

langium/packages/langium/src/workspace/document-builder.ts

Lines 423 to 428 in c3afb24

	if (uri) {
	const document = this.langiumDocuments.getDocument(uri);
	if (document && document.state > state) {
	return Promise.resolve(uri);
	}
	}

On the other hand, the fallback check for the workspace only requires the same or more advanced state:

langium/packages/langium/src/workspace/document-builder.ts

Lines 429 to 433 in c3afb24

	if (this.currentState >= state) {
	return Promise.resolve(undefined);
	} else if (cancelToken.isCancellationRequested) {
	return Promise.reject(OperationCancelled);
	}

Link to code example:

The current behavior

waitUntil never resolves (unless the document is rebuilt later) if the document is available in the target state.

The expected behavior

waitUntil should resolve immediately if the document is already available in the desired state. Or at least that's what I think I'd expect.

[msujew]

Ah, damn. That was supposed to be a >=. I'll submit a fix for that tomorrow :)

[colin-grant-work]

That was supposed to be a >=.

Thought so, but I just started working with Langium, so I didn't want to assume there was a reason I couldn't divine. :-)