Perform Maven target dependency update in non-UI thread #1901
Conversation
Test Results 321 files ±0 321 suites ±0 52m 18s ⏱️ -13s For more details on these errors, see this check. Results for commit d49118a. ± Comparison against base commit 19c8f09. This pull request removes 1 test.♻️ This comment has been updated with latest results. |
ptziegler
force-pushed
the
non-blocking-maven-update
branch
3 times, most recently
from
f49b773 to
1a4d43c
Compare
| @@ -316,7 +312,7 @@ public void testUpdateMavenArtifactVersion() throws Exception { | |||
|
|
|||
| table.select(12); | |||
| robot.button("Update").click(); | |||
| readAndDispatch(); | |||
There was a problem hiding this comment.
The test is executed too fast. Because the update is now done in a separate thread, we get the "The wizard can't be closed because of an active operation" popup when trying to close it.
ptziegler
force-pushed
the
non-blocking-maven-update
branch
2 times, most recently
from
fdb0de1 to
7a69cf7
Compare
Depending on how many artifacts are updated, this might be a long-running operation and should therefore be run without blocking the application.
akurtakov
force-pushed
the
non-blocking-maven-update
branch
from
7a69cf7 to
d49118a
Compare
|
@ptziegler can you check with latest release? I Think that I should have fixed this in PDE so it performs updates in a separate thread. If not let me know I think this is better handled in the PDE editor than directly in the target location implementation. |
Depending on how many artifacts are updated, this might be a long-running operation and should therefore be run without blocking the application.