-
Notifications
You must be signed in to change notification settings - Fork 0
target platform strategy #14
Comments
@BeckerFrank what is the use case of supporting numerous targets? Perhaps, an ability to be installed for older Eclipse Platform without conflicts. Personally, I think this is nice to have. But, it may be much harder than switching a .target file or even hardly possible. Examples:
Let's range our priorities
|
Yes this can be maybe impossible. This is why Mylyn tried to be compatible with very old versions.
Yes! BTW: The Eclipse-Installer points to the new Mylyn.setup (GitHub URL) and can be used for an easy setup of an new Eclipse Instance. |
Good to know. We also still support Java 8 in Eclipse Passage (engine only) and I understand the challenge. I think if we can enumerate these "kernel" bundles that we want to be extra-compartible - the task will become realisitc. Please help to collect this info.
Thanks! I'm a fan of Oomph too. No idea how I managed to overlook the Mylyn.setup |
<copy/paste> I agree with Alexander that the repos should be self-sufficient. However, it is also the case that some repos have to be built before others. common itself is in use by other downstream repositories. This requires a cascading build setup: When commons is built, it must trigger its downstream builds. We can also look at commons (and other upstream repos) as just another third-party dependency. It means that downstream repositories are built with whatever common is currently in the snapshot/nightly repo. When a release is planned, we can make one build that cascades all builds into proper order and then release that result. Is there a graph that shows the mylyn internal dependency tree? |
(In reply to comment #4)
No there is no dependency tree. The following classes need some parts from org.eclipse.mylyn.context
Here the other dependiencies I know org.eclipse.myln.commons is used by
org.eclipse.myln.tasks is used by
org.eclipse.myln.versions is used by
|
One more detail.
|
I'm not sure that I understand this approach @BeckerFrank . If we run unit tests per-repository, what is the value to run the same tests again? |
I've created #19 to let aggregator resolve test bundles from "common".
|
For historical reasons we have one place org.eclipse.mylyn.tests where we have all the Entry Test defined. |
@wimjongman @BeckerFrank we still have no answer what is the lowest Eclipse version we would like to support. |
I think we have the following options
For all options we should keep in mind that the OOMPH Query Setup Task fetch the version from https://download.eclipse.org/mylyn/releases/latest and this can break all *.setups with "Mylyn Build" and "Mylyn Query" task for Eclipse Versions before the supported Version. I prefer that we try 4. because "IBM Developer for z/OS" latest version (16.0.0) is based on 2022-03 and my employer use this product and we also have Mylyn. Thougths? |
From my side it looks like the following:
|
Thank you for the details @merks ! Do you have any incoming constraints for mentioned bundles from Oomph side? Like BREE, supported Eclipse Platform version, whatever else..? |
What is the reason for supporting older Eclipse versions? I can think of only one reason: to allow new Mylyn functions to be available in older versions.
If people want to use an old Eclipse version, then there is always a Mylyn version that supports that version. In short, I see no reason to support older Eclipse releases. Meaning that if you want to use an old Eclipse version, then you also have to install an old compatible Mylyn version. |
This depends on the p2 updatesite you use. For mylyn I think most people use https://download.eclipse.org/mylyn/releases/latest and do not use a version specific mylyn download like https://download.eclipse.org/mylyn/releases/3.25/. In the past the mylyn project has the same minimal Eclipse Version for every new version so there was no need to look what version is needed for a new installation. In the future we maybe need to tell them that the use https://download.eclipse.org/mylyn/releases/3.25/ for installations before some specific Eclipse version because https://download.eclipse.org/mylyn/releases/latest requires a newer Eclipse version. |
Yes. We need to make that clear. I agree. Is it not the case that Mylyn is included in most release train repositories? |
Perhaps it will be better to have something like https://download.eclipse.org/mylyn/releases/20xx-yy/ that redirects to a specific Mylyn release. |
Yes Mylyn was in the release train until 2022-03 after this only Mylyn WikiText is included. |
Add gerrit bundles to target Signed-off-by: Alexander Fedorov <[email protected]>
Add gerrit bundles Signed-off-by: Alexander Fedorov <[email protected]>
We actual have the targets in two places.
I add the targets for 4.23 - 4.25
So maybe we should look that we can
What is the way we want to go?
The text was updated successfully, but these errors were encountered: