Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate two thrstatetest #21020

Open
llxia opened this issue Jan 26, 2025 · 2 comments
Open

Consolidate two thrstatetest #21020

llxia opened this issue Jan 26, 2025 · 2 comments
Assignees
@dennycjacob
Labels
comp:test

Comments

@llxia
Copy link
Contributor

llxia commented Jan 26, 2025

There are two thrstatetest. The only difference is that -Djava.home value. One points to jre folder and the other one does not. We can consolidate two thrstatetest into one.

openj9/test/functional/NativeTest/playlist.xml

Line 482 in 1c0f64e

<testCaseName>thrstatetest</testCaseName>

openj9/test/functional/NativeTest/playlist.xml

Line 515 in 1c0f64e

<testCaseName>thrstatetest</testCaseName>

Check if JAVA_HOME is set properly for JDK8 and JDK11+. If not, value can be set in https://github.com/eclipse-openj9/openj9/blob/1c0f64e5dc463dcb9e559b59dbac0c395787419e/test/functional/NativeTest/nativeTestSettings.mk
@llxia llxia mentioned this issue Jan 26, 2025
Merged
@llxia
Copy link
Contributor Author

llxia commented Jan 26, 2025

@dennycjacob please take a look. Thanks

@dennycjacob
Copy link

Thanks @llxia . I will look into the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dennycjacob dennycjacob

Labels
comp:test
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@llxia @dennycjacob