You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
-[ ] Update the build qualifiers to ensure that packages are all updated. See this [gerrit](https://git.eclipse.org/r/#/c/161075/) for an example. To do this run `releng/org.eclipse.epp.config/tools/setGitDate` ([link](https://github.com/eclipse-packaging/packages/blob/master/releng/org.eclipse.epp.config/tools/setGitDate)) script. This script will make a local commit you need to push.
Because if you squash or amend the commit so the commit time is overridden the effect goes away as the commit time, not the author time is used.
This results in the following manual check to potentially fail:
-[ ]`org.eclipse.epp.package.*` features and bundles have the timestamp of the forced qualifier update or later
The utility of the force qualifier updates is to make sure that we don't publish content with the same version + qualifier but produced at different times.
Perhaps it would be easier to simply remove these steps and stop using the jgit timestamp plug-in and always use build time for the bundles qualifier. I think that would achieve the goal without the overhead.
PS I think there was also the desire to have the timestamps be "pretty" in the past, i.e. org.eclipse.epp.package.common_4.32.0.20240530-1200 instead of org.eclipse.epp.package.common_4.32.0.20240530-0533/
Note that the RC1 (see #166) shows the inconsistency (the build is still ok) because the commit that set the timestamp has different commit and author times. The setGitData script sets the commit date:
Yes, I wondered about that. If you want each build to produce new artifacts, why use the commit time and need to make a commit to change it... Of course there is the issue of reproducible builds too...
The force qualifier updates build step is a little brittle, this step:
packages/RELEASING.md
Line 59 in cdbc520
Because if you squash or amend the commit so the commit time is overridden the effect goes away as the commit time, not the author time is used.
This results in the following manual check to potentially fail:
packages/RELEASING.md
Line 76 in cdbc520
The utility of the force qualifier updates is to make sure that we don't publish content with the same version + qualifier but produced at different times.
Perhaps it would be easier to simply remove these steps and stop using the jgit timestamp plug-in and always use build time for the bundles qualifier. I think that would achieve the goal without the overhead.
PS I think there was also the desire to have the timestamps be "pretty" in the past, i.e.
org.eclipse.epp.package.common_4.32.0.20240530-1200
instead oforg.eclipse.epp.package.common_4.32.0.20240530-0533/
Note that the RC1 (see #166) shows the inconsistency (the build is still ok) because the commit that set the timestamp has different commit and author times. The setGitData script sets the commit date:
packages/releng/org.eclipse.epp.config/tools/setGitDate
Line 7 in 54cfc2a
But the commit for RC1 was different cdbc520
The text was updated successfully, but these errors were encountered: