Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review/revisit for qualifier updates #169

Open
jonahgraham opened this issue May 30, 2024 · 1 comment
Open

Review/revisit for qualifier updates #169

jonahgraham opened this issue May 30, 2024 · 1 comment

Comments

@jonahgraham
Copy link
Contributor

The force qualifier updates build step is a little brittle, this step:

- [ ] Update the build qualifiers to ensure that packages are all updated. See this [gerrit](https://git.eclipse.org/r/#/c/161075/) for an example. To do this run `releng/org.eclipse.epp.config/tools/setGitDate` ([link](https://github.com/eclipse-packaging/packages/blob/master/releng/org.eclipse.epp.config/tools/setGitDate)) script. This script will make a local commit you need to push.

Because if you squash or amend the commit so the commit time is overridden the effect goes away as the commit time, not the author time is used.

This results in the following manual check to potentially fail:

- [ ] `org.eclipse.epp.package.*` features and bundles have the timestamp of the forced qualifier update or later

The utility of the force qualifier updates is to make sure that we don't publish content with the same version + qualifier but produced at different times.

Perhaps it would be easier to simply remove these steps and stop using the jgit timestamp plug-in and always use build time for the bundles qualifier. I think that would achieve the goal without the overhead.

PS I think there was also the desire to have the timestamps be "pretty" in the past, i.e. org.eclipse.epp.package.common_4.32.0.20240530-1200 instead of org.eclipse.epp.package.common_4.32.0.20240530-0533/

Note that the RC1 (see #166) shows the inconsistency (the build is still ok) because the commit that set the timestamp has different commit and author times. The setGitData script sets the commit date:

export GIT_COMMITTER_DATE="${GIT_DATE}"

But the commit for RC1 was different cdbc520

@merks
Copy link
Contributor

merks commented May 30, 2024

Yes, I wondered about that. If you want each build to produce new artifacts, why use the commit time and need to make a commit to change it... Of course there is the issue of reproducible builds too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants