Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Springify Journal Loader #1037

Open
rpoet-jh opened this issue Aug 26, 2024 · 2 comments
Open

Springify Journal Loader #1037

rpoet-jh opened this issue Aug 26, 2024 · 2 comments

Comments

@rpoet-jh
Copy link
Contributor

What?

The pass-support/pass-journal-loader should be converted to a Spring Boot project. The other data loaders are already Spring Boot projects.

Why?
To be consistent with the other data loaders, and to remove boiler plate code.

Acceptance Criteria
pass-support/pass-journal-loader is Spring Boot.

@rpoet-jh rpoet-jh converted this from a draft issue Aug 26, 2024
@eclipse-pass eclipse-pass deleted a comment Aug 26, 2024
@jabrah
Copy link
Contributor

jabrah commented Aug 26, 2024

As a reminder, we can only accept changes through pull requests through GitHub. Please see our contribution guidelines for more information!

@rpoet-jh
Copy link
Contributor Author

rpoet-jh commented Oct 7, 2024

When journal loader is converted to a spring app, we should also enable loading app props from aws param store. See this PR for example of how it is done: eclipse-pass/pass-support#126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

3 participants
@jabrah @rpoet-jh and others