-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backport: Use the actual system-packages from the JVM for export #16
backport: Use the actual system-packages from the JVM for export #16
Conversation
surprisingly, |
o.e.pde.core always lived in PDE's 'main' repo and was never in this one. Probably the best is to have both repos checked out at the R4_23 branch and import the pde.build projects from this repo and then make it work. |
…e export Fixes eclipse-pde/eclipse.pde#194 for PDE-build Refs: eclipse-pde/eclipse.pde#624
4eb058e
to
e88f175
Compare
@@ -26,6 +26,8 @@ Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.2.0,4.0.0)", | |||
org.eclipse.equinox.p2.repository.tools;bundle-version="[2.0.0,3.0.0)";resolution:=optional, | |||
org.eclipse.equinox.p2.director.app;bundle-version="1.0.200", | |||
org.eclipse.equinox.p2.publisher.eclipse;bundle-version="1.0.0" | |||
org.eclipse.jdt.core;bundle-version="[3.28.0,4.0.0)", | |||
org.eclipse.jdt.launching;bundle-version="[3.2.0,4.0.0)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi - this is the only change that was required for the back port on top of @HannesWell 's original PR
from org.eclipse.jdt.launching;bundle-version="[3.19.700,4.0.0)"
to org.eclipse.jdt.launching;bundle-version="[3.2.0,4.0.0)"
to match what is in there for 4.23
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for that reason I intent to keep the second commit as is rather than squashing, but let me know if you think otherwise. (I understand that each project may have different rules)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's reasonable, would keep it separated too.
" > surprisingly,
Yes, also knowing that the change is in 1-2 files ( max 3 files) should make this easier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
But I havn't checked the code, assuming you left it unchanged.
yes, no change in the code except downgrading of |
- add a missing comma in the manifest - bump the bundle version Refs: eclipse-pde#16
- add a missing comma in the manifest - bump the bundle version Refs: #16
Fixes eclipse-pde/eclipse.pde#194 for PDE-build in 4.23
Refs: eclipse-pde/eclipse.pde#624
/cc @HannesWell