From d7b4ba719336c7f6cb161d42a984710a703dd5d8 Mon Sep 17 00:00:00 2001 From: Vikas Chandra <99390647+vik-chand@users.noreply.github.com> Date: Fri, 18 Mar 2022 14:28:20 +0530 Subject: [PATCH] Model Spy List tab not accessible with keyboard only #2 (#3) Signed-off-by: Vikas Chandra --- .../eclipse/e4/tools/emf/ui/internal/Messages.java | 2 ++ .../e4/tools/emf/ui/internal/Messages.properties | 12 +++++++----- .../ui/internal/common/component/tabs/ListTab.java | 4 ++-- 3 files changed, 11 insertions(+), 7 deletions(-) diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/Messages.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/Messages.java index f441cb1eb3..d556c35d00 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/Messages.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/Messages.java @@ -796,6 +796,8 @@ public class Messages { public String ListTab_col_item; public String ListTab_col_label; public String ListTab_col_go; + public String ListTab_col_go2; + public String ListTab_elementId; public String ListTab_addColumn; public String ListTab_filterByAttribute; diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/Messages.properties b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/Messages.properties index d692591457..8151dbfda0 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/Messages.properties +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/Messages.properties @@ -801,16 +801,18 @@ ListTab_7=Showing items with attribute: ListTab_8=xmi ListTab_9=form ListTab_col_id=ID -ListTab_col_item=Item +ListTab_col_item=&Item ListTab_col_label=Label -ListTab_col_go=Go +ListTab_col_go=&Go +ListTab_col_go2=G&o ListTab_addColumn=Add &Column ListTab_filterByAttribute=Filter By Attri&bute -ListTab_filterByItem=Filter By &Item -ListTab_mark=Mark +ListTab_filterByItem=Filter B&y Item +ListTab_mark=Mar&k +ListTab_elementId=Eleme&nt ID ListTab_markAttribute=&Filter By Attribute -ListTab_removeFilter=Rem&ove Filter +ListTab_removeFilter=Remo&ve Filter ListTab_more=&More ListTab_resetColumns=Rese&t Columns ListTab_selectAnAttribute=Select an attribute diff --git a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/tabs/ListTab.java b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/tabs/ListTab.java index f05f16aa8d..e8eda9022d 100644 --- a/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/tabs/ListTab.java +++ b/bundles/org.eclipse.e4.tools.emf.ui/src/org/eclipse/e4/tools/emf/ui/internal/common/component/tabs/ListTab.java @@ -520,7 +520,7 @@ public String getText(Object element) { }); colGoXmi = new TableViewerColumn(tvResults, SWT.NONE); - colGoXmi.getColumn().setText(Messages.ListTab_col_go); + colGoXmi.getColumn().setText(Messages.ListTab_col_go2); requiredColumns.put("GoXmi", colGoXmi.getColumn()); //$NON-NLS-1$ colGoXmi.setLabelProvider(new ColumnLabelProvider() { @Override @@ -582,7 +582,7 @@ public String getText(Object element) { app.getContext().set("org.eclipse.e4.tools.active-object-viewer", this); //$NON-NLS-1$ final EAttributeTableViewerColumn colId = new EAttributeTableViewerColumn(tvResults, - "elementId", "elementId", context); //$NON-NLS-1$//$NON-NLS-2$ + Messages.ListTab_elementId, "elementId", context); //$NON-NLS-1$ defaultColumns.put("elementId", colId); //$NON-NLS-1$ final EAttributeTableViewerColumn colLabel = new EAttributeTableViewerColumn_Markable(tvResults,