-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix undo / redo icons according to standard #113
Comments
There are many icons that need to be fixed. It's hard to say from your first screenshot if they are not aligned properly. In the second screenshot it is obvious. I needed 1.5 hours to remake the other two icons and disabled variants and place them into Eclipse. Right now I don't have time to fix all the icons so I focus on only fixing the SVGs that can't be rasterized properly with JSVG as this is directly related with my project. I think we should still create issues for the problems just to gather them and get a feeling about how much work it would be. |
True, I picked these two because they are very much visible.
Your pull request was so fast, that I had hope that you had tools for this and that this would be super fast for you. @BeckerWdf can you maybe help here with these two icons? |
Contributes to: eclipse-platform#113
Contributes to: eclipse-platform#113
Done. See my 3 PRs. |
Thanks @BeckerWdf |
AFAICS these two icons are also not aligned according to #108
@Michael5601 WDYT?
The text was updated successfully, but these errors were encountered: