Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undo / redo icons according to standard #113

Closed
vogella opened this issue Nov 28, 2024 · 5 comments
Closed

Fix undo / redo icons according to standard #113

vogella opened this issue Nov 28, 2024 · 5 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@vogella
Copy link
Contributor

vogella commented Nov 28, 2024

AFAICS these two icons are also not aligned according to #108

@Michael5601 WDYT?

image

@vogella vogella added the bug Something isn't working label Nov 28, 2024
@vogella
Copy link
Contributor Author

vogella commented Nov 28, 2024

image

@Michael5601
Copy link
Contributor

There are many icons that need to be fixed. It's hard to say from your first screenshot if they are not aligned properly. In the second screenshot it is obvious.

I needed 1.5 hours to remake the other two icons and disabled variants and place them into Eclipse. Right now I don't have time to fix all the icons so I focus on only fixing the SVGs that can't be rasterized properly with JSVG as this is directly related with my project.

I think we should still create issues for the problems just to gather them and get a feeling about how much work it would be.

@vogella
Copy link
Contributor Author

vogella commented Nov 28, 2024

There are many icons that need to be fixed.

True, I picked these two because they are very much visible.

I needed 1.5 hours to remake the other two icons and disabled variants and place them into Eclipse.

Your pull request was so fast, that I had hope that you had tools for this and that this would be super fast for you.

@BeckerWdf can you maybe help here with these two icons?

BeckerWdf added a commit to BeckerWdf/eclipse.platform.images that referenced this issue Nov 28, 2024
BeckerWdf added a commit to BeckerWdf/eclipse.platform.ui that referenced this issue Nov 28, 2024
BeckerWdf added a commit to BeckerWdf/eclipse.platform.releng.aggregator that referenced this issue Nov 28, 2024
BeckerWdf added a commit to BeckerWdf/eclipse.platform.images that referenced this issue Nov 28, 2024
@BeckerWdf
Copy link
Contributor

@BeckerWdf can you maybe help here with these two icons?

Done. See my 3 PRs.

@BeckerWdf BeckerWdf self-assigned this Nov 28, 2024
@BeckerWdf BeckerWdf added this to the 4.35 M1 milestone Nov 28, 2024
BeckerWdf added a commit to eclipse-platform/eclipse.platform.releng.aggregator that referenced this issue Nov 28, 2024
BeckerWdf added a commit to BeckerWdf/eclipse.platform.ui that referenced this issue Nov 28, 2024
BeckerWdf added a commit that referenced this issue Nov 28, 2024
vogella pushed a commit to eclipse-platform/eclipse.platform.ui that referenced this issue Nov 28, 2024
@vogella
Copy link
Contributor Author

vogella commented Nov 28, 2024

Thanks @BeckerWdf

@vogella vogella closed this as completed Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants