-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update site - "Eclipse Platform SDK" feature is missing #2126
Comments
I think you have to use the now. IIRC the SDK feature was removed. cc @HannesWell who might know more details |
I'm not aware that the org.eclipse.sdk feature was removed and it is still in (heavy?) use. |
I extracted the This is some of that xml: <unit id="org.eclipse.platform.sdk" version="4.29.0.I20230903-1000">
<update id="org.eclipse.platform.sdk" range="[4.0.0,4.29.0.I20230903-1000)" severity="0" description="An update for 4.x generation Platform SDK"/>
<properties size="5">
<property name="org.eclipse.equinox.p2.name" value="Eclipse Platform SDK"/>
<property name="org.eclipse.equinox.p2.type.product" value="true"/>
<property name="org.eclipse.equinox.p2.type.group" value="true"/>
<property name="org.eclipse.equinox.p2.description" value="4.29 Release of the Platform SDK."/>
<property name="org.eclipse.equinox.p2.provider" value="Eclipse.org"/>
</properties>
(Note, I have no need of this feature myself, I'm just reporting it in case this is a bug) |
This is result of #1235 in which products and features have been reduced to more manageable list. |
OK, thanks for the info. I just thought I would report this in case of problems. As the group category "Eclipse Platform SDK" is now empty should that also be removed? (Sorry, I don't know where/how that is so can't provide PR) |
That's right. Sorry I assumed we are talking about a feature. But if you are looking for a replacement in your target-platform, I suggest to use the
That sounds reasonable, but I cannot find where it is defined. |
It's showing in the update dialog. Strange. |
One has to look in the right place. A release repository is a composite:
So you have to look here: https://download.eclipse.org/justj/?file=eclipse/updates/4.32/categories Where that comes from is not yet clear. It defines its contents by requiring IU
And that has been removed. |
I really can't find where this comes from. E.g., here it is again in the 4.33-I-builds: https://download.eclipse.org/eclipse/updates/4.33-I-builds/categories/content.jar Maybe it's just copied from one place to another each time. The generated report: Shows that it's empty: |
This is copied from template format while creating new stream. https://download.eclipse.org/eclipse/updates/template_repo/ |
So "we" should fix these:
Probably also this: and maybe also these
Here is the modified content.jar renamed to append .zip so I can drop it here: |
let me check and do |
Can confirm the empty category is gone now in the 4.30, 4.31 and 4.32 update sites. Thanks! |
CLosing as per previous comments |
Thank you! 😀 |
Thank you for fixing that! Ideally these categories would be defined in some 'source' files and not only in binaries. Do you think this would be possible? |
Can Tycho build the following content with a category.xml with only category definitions, building only a content metadata repository not an artifact repository? Note that the things included in each category will not necessarily exist and will not be included in the site itself. I think that's all a bit tricky and is likely not supported.
|
@merks the "update-site" packaging can be sourced from various sources:
none of them is mandatory... The mojo used there is tycho-p2-repository:assemble-repository has a parameter createArtifactRepository that can skip generation of artifact repository, you can also set the name, properties and so on. The advanced syntax supported by P2/Tycho in category.xml is explained here. So I think its just a matter of creativity to combine all those to create such thing "from code", one even can define everything in a |
Yes, problems to be solved are generally a matter of sufficient creativity along available time. Where there's a will, there's a way... Also, there is generally a list of all problems that one might spend time trying to resolve and the prioritization within that list of any particular problem. So who will prioritize this problem to the top of their queue? 👼 |
If one think its useful just create an issue and describe the input and the desired outcome, I'll try to take a look, I just wanted to note that actually the tooling should be there... I just don't know about where / when / why / ... about this. |
A simple solution is to keep the content.xml is source from, build a jar from it, and call it done.. If I understand the problem correctly we'd want to maintain this entire thing in source form so that we can change it and find it in the future rather than knowing to look here: |
A bit hacky, but definitively better than the current situation. 😅 Btw. can't we just define the category as usual in the eclipse.platform.repository/category.xml? Or is it necessary to maintain the categories in a sub-repo? |
I'm not sure if there is a specific reason to avoid having the categories redefined separately (and in duplicate) in each and every simple repository. I tested a site that is a composite where each child does define the categories and p2 does unify them even though each category IU has a different version: So I don't know of a compelling reason or any reason not to define this in the category.xml in the normal way. Probably just for historical reasons. |
Since Eclipse 4.30 the "Eclipse Platform SDK" feature is missing from the update site.
https://download.eclipse.org/eclipse/updates/4.32
(or 4.30 or 4.31) as the update siteIn previous releases the "Eclipse Platform SDK" feature was present. Example:
The text was updated successfully, but these errors were encountered: