Remove transitively included o.e.osgi.util from o.e.platform feature #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hannes Wellmann <[email protected]>
|
Looks good to me. |
|
Yes there is no need to directly include a bundle in a feature when that bundle is directly included by a transitively included feature. Thanks for investigating this with such diligence! |
|
Great!
You are welcome. :) By the way, the sources of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plug-in
org.eclipse.osgi.utilis already included inorg.eclipse.e4.rcpand therefore transitively in theorg.eclipse.platformfeature viaorg.eclipse.rcp.Tycho/P2 considers transitive inclusion already for a long time and with the latest changes in 4.23 and 4.24 PDE supports it as well when launching applications/products and I think even with older versions product launches should work as well because PDE 'manually' included transitively included plugin to the launch. So this can be removed to reduce the maintenance effort (e.g. as a consequence of eclipse-equinox/equinox.framework#41).
@merks Do you agree that this is okay?