-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SWT Display class not marked as @noextend on MacOS #1043
Comments
I can confirm that: when extending |
Describe the bug
The
.api_description
embedded in theo.e.swt.cocoa.macosx.aarch64|x86_64
artifacts lists theorg.eclipse.swt.widgets.Display
class, with<type name="Display" restrictions="0">
while for other platforms it is<type name="Display" restrictions="2">
.The attribute
restrictions="2"
represents the@noextend
whilerestrictions="0"
means no restriction:https://github.com/eclipse-pde/eclipse.pde/blob/bc22b075c0a617d77ea261b77581e09bdae839aa/apitools/org.eclipse.pde.api.tools/src/org/eclipse/pde/api/tools/internal/provisional/RestrictionModifiers.java#L28-L36
Consequently this means that the
Display
class is effectively not restricted and not marked as@noextend
at Mac OS, although it is actually marked as such like for all other platforms:eclipse.platform.swt/bundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/Display.java
Line 105 in 8dc46be
I have checked the latest release 4.30 and the current I-build and in both the .api_description looks as described, so I assume this issue exists for longer. But it only seems to become visible at some occasions like #1011 (comment).
@Phillipus or @HeikoKlare can you verify on Mac that this error really manifests itself and is not just hypothetical? For example in a workspace that has SWT only in its TP can you create a class that extends Display and get a corresponding API problem?
The text was updated successfully, but these errors were encountered: