Replace "fail on warning" with Jenkins quality gate #1030
Conversation
There was a problem hiding this comment.
Disabling failOnWarning makes sense to me, but we should then activate the quality gate, similar like it is done for example in PDE:
Although the exact settings are controversially discussed: eclipse-platform/eclipse.platform#1046
I agree. Maybe we can have that as a direct follow-up PR? In case we need some experiments or discussion on the quality gate configuration, it will not block the failOnWarning disablement from being merged. Currently this makes all builds fail due to eclipse-platform/eclipse.platform.releng.aggregator#1774, and since warnings have simply been ignored before, this option never had any effect. |
I'm also fine to do that as a follow up, if you prefer to discuss the exact settings first. But I would also be fine to apply only the weaker settings now, that only require no new warnings for the Compiler (which also includes API errors) and discuss later to make it more strict. Your call :)
Only for those warnings being ignored, not the once that were not ignored. |
The GitHub Actions and Jenkins build specifications currently contain the option `-Dmaven.compiler.failOnWarning=true`. Since warnings were defined to be ignored in the parent POM, this did not have any effect. The configuration to ignore warnings has been removed from the parent POM, so that the builds now fail as the code actually contains warnings. This change removes the "fail on warning" option. As a replacement, it enables Jenkins quality gate.
HeikoKlare
force-pushed
the
disable-failOnWarning
branch
from
b594376 to
41c66df
Compare
True. Then removing the configuration option without enabling the quality gate would actually weaken the checks. I have added a quality gate configuration, which, from my understanding, should be rather weak. So we can see if that works fine and then apply a stricter one later on. |
HeikoKlare
changed the title
…exe" extension Before commit 97ca656 `SHGetFileInfo` was used initially to get the icon. This caused problems for some icons (eclipse-platform#715). The fix in commit 97ca656 removed the `SHGetFileInfo` invocation which caused a new problem that for some file extensions, e.g. `.exe`, no icon was returned any more. This fix re-introduces the `SHGetFileInfo`, but only uses it if `ExtractIconEx` did not return an icon. See: eclipse-platform#1030: eclipse-platform#1130 eclipse-platform#715: eclipse-platform#715
…exe" extension Before commit 97ca656 `SHGetFileInfo` was used initially to get the icon. This caused problems for some icons (eclipse-platform#715). The fix in commit 97ca656 removed the `SHGetFileInfo` invocation which caused a new problem that for some file extensions, e.g. `.exe`, no icon was returned any more. This fix re-introduces the `SHGetFileInfo`, but only uses it if `ExtractIconEx` did not return an icon. See: eclipse-platform#1030: eclipse-platform#1130 eclipse-platform#715: eclipse-platform#715
…exe" extension Before commit 97ca656 `SHGetFileInfo` was used initially to get the icon. This caused problems for some icons (eclipse-platform#715). The fix in commit 97ca656 removed the `SHGetFileInfo` invocation which caused a new problem that for some file extensions, e.g. `.exe`, no icon was returned any more. This fix re-introduces the `SHGetFileInfo`, but only uses it if `ExtractIconEx` did not return an icon. See: eclipse-platform#1030: eclipse-platform#1130 eclipse-platform#715: eclipse-platform#715
The GitHub Actions and Jenkins build specifications currently contain the option
-Dmaven.compiler.failOnWarning=true. Since warnings were defined to be ignored in the parent POM, this did not have any effect. The configuration to ignore warnings has been removed from the parent POM, so that the builds now fail as the code actually contains warnings.This change removes the "fail on warning" option. As a replacement, it enables Jenkins quality gate.
See eclipse-platform/eclipse.platform.releng.aggregator#1774