From 54ccb16587682dd86f6d32784627179cee9420eb Mon Sep 17 00:00:00 2001 From: fedejeanne Date: Thu, 14 Nov 2024 10:23:00 +0100 Subject: [PATCH] Add warning in preferences dialog Add a warning about flickering effects caused by the Edge browser under Preferences > General > Appearance. --- .../eclipseui/org/eclipse/ui/internal/WorkbenchMessages.java | 2 ++ .../org/eclipse/ui/internal/dialogs/ViewsPreferencePage.java | 3 ++- .../eclipseui/org/eclipse/ui/internal/messages.properties | 1 + 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/WorkbenchMessages.java b/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/WorkbenchMessages.java index ec1e7cc8554..00d9e7e70b4 100644 --- a/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/WorkbenchMessages.java +++ b/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/WorkbenchMessages.java @@ -76,6 +76,8 @@ public class WorkbenchMessages extends NLS { public static String StatusUtil_errorOccurred; + public static String EdgeBrowserDisclaimer; + // ============================================================================== // Workbench Actions // ============================================================================== diff --git a/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/dialogs/ViewsPreferencePage.java b/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/dialogs/ViewsPreferencePage.java index cc76a5897fe..33488d98483 100644 --- a/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/dialogs/ViewsPreferencePage.java +++ b/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/dialogs/ViewsPreferencePage.java @@ -214,7 +214,8 @@ private void createHiDPISettingsGroup(Composite parent) { GridLayout layout = new GridLayout(1, false); group.setLayout(layout); Label infoLabel = new Label(group, SWT.WRAP); - infoLabel.setText(WorkbenchMessages.RescaleAtRuntimeDisclaimer); + infoLabel.setText(WorkbenchMessages.RescaleAtRuntimeDisclaimer + System.lineSeparator() + System.lineSeparator() + + WorkbenchMessages.EdgeBrowserDisclaimer); infoLabel.setLayoutData(GridDataFactory.defaultsFor(infoLabel).create()); createLabel(group, ""); //$NON-NLS-1$ diff --git a/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/messages.properties b/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/messages.properties index 08c857e04ff..bbf88a58b44 100644 --- a/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/messages.properties +++ b/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/internal/messages.properties @@ -505,6 +505,7 @@ RescaleAtRuntimeSettingChangeWarningText = Restart for the DPI setting changes t HiDpiSettingsGroupTitle = HiDPI settings RescaleAtRuntimeEnabled = Monitor-specific UI &scaling RescaleAtRuntimeDisclaimer = EXPERIMENTAL! Activating this option will dynamically scale all windows according to the monitor they are currently in. It will also set the default browser to Edge in order to provide the appropriate scaling of content displayed in a browser. This feature is still in development and therefore considered experimental. +EdgeBrowserDisclaimer = WARNING! Changing the size of the browser window can currently cause flickering effects, which are currently being resolved. People who are sensitive to this should therefore either not use Edge at the moment or possibly avoid resizing browser windows. # --- Workbench ----- WorkbenchPreference_openMode=Open mode WorkbenchPreference_doubleClick=D&ouble click