From d235146392776eb05fd774eac64482afada19cfe Mon Sep 17 00:00:00 2001 From: Lars Vogel Date: Wed, 6 Nov 2024 11:31:39 +0100 Subject: [PATCH] Mark unused methods for removal in WorkbenchWindowAdvisor These methods are not used since the 3.x migration, time to mark them for deletion. --- .../org/eclipse/ui/application/WorkbenchWindowAdvisor.java | 4 ++-- .../eclipse/ui/tests/rcp/WorkbenchWindowConfigurerTest.java | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/application/WorkbenchWindowAdvisor.java b/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/application/WorkbenchWindowAdvisor.java index 0d9d6f54bb4..136fde14cf7 100644 --- a/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/application/WorkbenchWindowAdvisor.java +++ b/bundles/org.eclipse.ui.workbench/eclipseui/org/eclipse/ui/application/WorkbenchWindowAdvisor.java @@ -272,7 +272,7 @@ public void postWindowClose() { * @deprecated This method is no longer used. Applications now define workbench * window contents in their application model. */ - @Deprecated + @Deprecated(forRemoval = true, since = "2024-12") public void createWindowContents(Shell shell) { ((WorkbenchWindowConfigurer) getWindowConfigurer()).createDefaultContents(shell); } @@ -291,7 +291,7 @@ public void createWindowContents(Shell shell) { * @deprecated This method is no longer used. Applications now define workbench * window contents in their application model. */ - @Deprecated + @Deprecated(forRemoval = true, since = "2024-12") public Control createEmptyWindowContents(Composite parent) { return null; } diff --git a/tests/org.eclipse.ui.tests.rcp/Eclipse RCP Tests/org/eclipse/ui/tests/rcp/WorkbenchWindowConfigurerTest.java b/tests/org.eclipse.ui.tests.rcp/Eclipse RCP Tests/org/eclipse/ui/tests/rcp/WorkbenchWindowConfigurerTest.java index 689d0398858..2a2aefe58cc 100644 --- a/tests/org.eclipse.ui.tests.rcp/Eclipse RCP Tests/org/eclipse/ui/tests/rcp/WorkbenchWindowConfigurerTest.java +++ b/tests/org.eclipse.ui.tests.rcp/Eclipse RCP Tests/org/eclipse/ui/tests/rcp/WorkbenchWindowConfigurerTest.java @@ -294,15 +294,15 @@ public IStatus saveState(IMemento memento) { }}; } + @SuppressWarnings("removal") @Override - @SuppressWarnings("deprecation") public Control createEmptyWindowContents(Composite parent) { ensureThread(); return super.createEmptyWindowContents(parent); } + @SuppressWarnings("removal") @Override - @SuppressWarnings("deprecation") public void createWindowContents(Shell shell) { ensureThread(); super.createWindowContents(shell);