Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement to the existing Light Theme #2103

Merged
merged 2 commits into from
Jul 20, 2024
Merged

Improvement to the existing Light Theme #2103

merged 2 commits into from
Jul 20, 2024

Conversation

mvm-sap
Copy link
Contributor

@mvm-sap mvm-sap commented Jul 18, 2024 •
edited
Loading

For the full details of the change including screenshots see issue: #2114

@mvm-sap
Improvement to the existing Light Theme
4319f36 
As part of Eclipse modernization project, we have enhanced the look and
feel of Eclipse IDE. This change includes improvements to the background
color of Views and working of tabs. This has been done with reference to
the other IDEs like VS Code, Intellij etc.
@laeubi
Copy link
Contributor

laeubi commented Jul 18, 2024

@mvm-sap please share Screenshot before/after the change

@vogella
Copy link
Contributor

vogella commented Jul 18, 2024

Please also adjust Linux light theme

@github-actions GitHub Actions
Copy link
Contributor

Test Results

 1 210 files   -     4   1 210 suites   - 4   1h 1m 14s ⏱️ - 15m 26s
 7 677 tests ±    0   7 446 ✅ +247  231 💤  -  2  0 ❌ ±0 
16 128 runs   - 1 024  15 615 ✅  - 759  513 💤  - 10  0 ❌ ±0 

Results for commit 4319f36. ± Comparison against base commit 8534560.

This pull request skips 3 and un-skips 5 tests. 
UiTestSuite org.eclipse.ui.tests.api.ApiTestSuite org.eclipse.ui.tests.api.WorkbenchPluginTest ‑ testGetImageRegistryFromAdditionalDisplay
org.eclipse.jface.text.tests.contentassist.ContextInformationTest ‑ testContextInfo_hide_focusOut
org.eclipse.urischeme.internal.registration.TestUnitWinRegistry ‑ testWinRegistry

org.eclipse.ui.genericeditor.tests.HoverTest ‑ testEnabledWhenHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testMultipleHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testProblemHover
org.eclipse.ui.genericeditor.tests.HoverTest ‑ testSingleHover
org.eclipse.ui.genericeditor.tests.ShowInformationTest ‑ testInformationControl

@thomasritter thomasritter mentioned this pull request Jul 19, 2024
Open
13 tasks
@mvm-sap
Copy link
Contributor Author

mvm-sap commented Jul 19, 2024

Please find the screenshots in the issue link provided : #2114

@thomasritter
Copy link

thomasritter commented Jul 19, 2024 •
edited
Loading

@vogella Adjusting the themes is very expensive. It took one person 3+ months to learn about how the themes work and get the Windows and Mac themes ready. Before we adjust the Linux theme we want to be sure that the Eclipse community approves the made changes and incorporate their feedback. Once Windows and Mac are finished we are fully committed to update the Linux theme.

@vogella vogella merged commit 9fd07c6 into eclipse-platform:master Jul 20, 2024
15 checks passed
@vogella
Copy link
Contributor

vogella commented Jul 20, 2024

LGTM on Windows.

@thomasritter and @mvm-sap please watch out for reported issues over the next days and please provide ASAP the Linux theme changes so that I can also test these changes in my daily usage (and of course to have consistant theming).

@mvm-sap mvm-sap deleted the New_Light_Theme branch July 22, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mvm-sap @laeubi @vogella @thomasritter