Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Texts not externalised #1236

Closed
2 tasks done
BeckerWdf opened this issue Mar 5, 2024 · 3 comments · Fixed by #1248
Closed
2 tasks done

Texts not externalised #1236

BeckerWdf opened this issue Mar 5, 2024 · 3 comments · Fixed by #1248
Labels
bug Something isn't working

Comments

@BeckerWdf
Copy link
Contributor

Let's make sure issue is not already fixed in latest builds first.

Steps to reproduce

Have a look at https://github.com/eclipse-platform/eclipse.platform/blob/a17ae73905f80cbd162cb17f96257c62fd63d2ed/team/bundles/org.eclipse.compare/compare/org/eclipse/compare/contentmergeviewer/TextMergeViewer.java#L5424C1-L5425C109

You see that the texts are not externalised and therefore cannot be translated.
This was overlooked in #731

Community

  • I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.
@BeckerWdf BeckerWdf added the bug Something isn't working label Mar 5, 2024
@BeckerWdf
Copy link
Contributor Author

@lathapatil: Can you provide a fix for this?

@lathapatil
Copy link
Contributor

lathapatil commented Mar 6, 2024 •
edited
Loading

@lathapatil: Can you provide a fix for this?

Yes. Can I create those strings in ICompareUIConstants.java file ?

@BeckerWdf
Copy link
Contributor Author

@lathapatil: Can you provide a fix for this?

Yes. Can I create those strings in ICompareUIConstants.java file ?

No. Pls. have a look at https://github.com/eclipse-platform/eclipse.platform/blob/master/team/bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/CompareMessages.java#L20

lathapatil added a commit to lathapatil/eclipse.platform that referenced this issue Mar 13, 2024
@lathapatil
Externalize the 'difference/s' text eclipse-platform#1236
8870f0d 
Externalization of text used in "Textmergeviewer.java" related to number
of differences shown in toolbar of compare editor.

Fixes eclipse-platform#1236
@lathapatil lathapatil mentioned this issue Mar 13, 2024
Merged
lathapatil added a commit to lathapatil/eclipse.platform that referenced this issue Mar 18, 2024
@lathapatil
Externalize the 'difference/s' text eclipse-platform#1236
c87e639 
Externalization of text used in "Textmergeviewer.java" related to number
of differences shown in toolbar of compare editor uaing
MessageFormat.format
lathapatil added a commit to lathapatil/eclipse.platform that referenced this issue Mar 18, 2024
@lathapatil
Externalize the 'difference/s' text eclipse-platform#1236
66c2f4d 
Externalization of text used in "Textmergeviewer.java" related to number
of differences shown in toolbar of compare editor using
MessageFormat.format
lathapatil added a commit to lathapatil/eclipse.platform that referenced this issue Mar 19, 2024
@lathapatil
Externalize the 'difference/s' text eclipse-platform#1236
5fbfba6 
Externalization of text used in "Textmergeviewer.java" related to number
of differences shown in toolbar of compare editor using
MessageFormat.format
lathapatil added a commit to lathapatil/eclipse.platform that referenced this issue Mar 19, 2024
@lathapatil
Externalize the 'difference/s' text eclipse-platform#1236
b726c79 
Externalization of text used in "Textmergeviewer.java" related to number
of differences shown in toolbar of compare editor using
MessageFormat.format
Version bump to 3.10.100
lathapatil added a commit to lathapatil/eclipse.platform that referenced this issue Mar 20, 2024
@lathapatil @BeckerWdf
Externalize the 'difference/s' text eclipse-platform#1236
b69f054 
Externalization of text used in "Textmergeviewer.java" related to number
of differences shown in toolbar of compare editor using
MessageFormat.format
Version bump to 3.10.100
Update team/bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/CompareMessages.properties

Co-authored-by: Matthias Becker <[email protected]>
BeckerWdf added a commit that referenced this issue Mar 25, 2024
@lathapatil @BeckerWdf
Externalize the 'difference/s' text #1236
072423e 
Externalization of text used in "Textmergeviewer.java" related to number
of differences shown in toolbar of compare editor using
MessageFormat.format
Version bump to 3.10.100
Update team/bundles/org.eclipse.compare/compare/org/eclipse/compare/internal/CompareMessages.properties

Co-authored-by: Matthias Becker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Externalize the 'difference/s' text #1236 lathapatil/eclipse.platform
2 participants
@BeckerWdf @lathapatil