Fix for RejectedExecutionException during delete operations #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the tasks scheduled by ForkJoinPool are all busy and new task is added, the pool would throw RejectedExecutionException if the "saturate" Predicate is not specified. To avoid that, supply Predicate that is always true - with that, no exception will be thrown on busy pool and we would not reject new delete operations. Fixes eclipse-platform#1592
|
@akurtakov : I plan to trigger new IBuild just to make sure this fix (or original issue) doesn't have any relationship to OOM's in eclipse-platform/eclipse.platform.ui#2432 |
|
Go for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the tasks scheduled by ForkJoinPool are all busy and new task is added, the pool would throw RejectedExecutionException if the "saturate" Predicate is not specified.
To avoid that, supply Predicate that is always true - with that, no exception will be thrown on busy pool and we would not reject new delete operations.
Fixes #1592