Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdf4j-queryresultio-sparqljson incompatible with Jackson 2.7+ #308

Closed
abrokenjester opened this issue Aug 31, 2016 · 5 comments
Closed

rdf4j-queryresultio-sparqljson incompatible with Jackson 2.7+ #308

abrokenjester opened this issue Aug 31, 2016 · 5 comments
Labels
🐞 bug issue is a bug
Milestone

Comments

@abrokenjester
Copy link
Contributor

Related to #273

Currently the RDF4J code is using a method in rdf4j-queryresultio-sparqljson (Lf2SpacesIndenter) that doesn't exist in Jackson 2.7+ as Jackson have a policy where they remove public APIs across minor versions.

See user forum report at https://groups.google.com/d/msg/rdf4j-users/hE74OxX9Ijw/vVF9gUf5AQAJ

@abrokenjester abrokenjester added the 🐞 bug issue is a bug label Aug 31, 2016
@abrokenjester abrokenjester added this to the 2.0.1 milestone Aug 31, 2016
@ansell
Copy link
Contributor

ansell commented Aug 31, 2016

For reference, the discussion between myself and the Jackson maintainer relating to this is at:

FasterXML/jackson-core#308

@ansell
Copy link
Contributor

ansell commented Aug 31, 2016

I will work on this btw.

@ansell
Copy link
Contributor

ansell commented Aug 31, 2016

Would it be an inconvenience if I updated the 2.0.1-SNAPSHOT Jackson dependency to 2.8.2 that was released 48 hours ago as part of this pull request?

I had two pull requests for jackson-dataformat-csv merged in 2.8.2 and it would be great to be able to reuse them both here in the near future to replace opencsv.

@ansell
Copy link
Contributor

ansell commented Aug 31, 2016

I have verified with the changes I am making so far that both 2.6.2 and 2.8.2 work, so I can leave the version bump for another time if that suits.

@abrokenjester
Copy link
Contributor Author

I'd prefer not doing this in the release branch as it means we will be blocked from doing a patch release until we have approval for the new version of Jackson (and also because bumping major dependency versions as part of a patch release is not quite kosher). I suggest we only do the quick fix to make the immediate problem go away in the release branch, and schedule a jackson version bump for the master branch instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug issue is a bug
Projects
None yet
Development

No branches or pull requests

2 participants