From 3496df6d54e3a77e2fa63600f9ce1f4eac0cb524 Mon Sep 17 00:00:00 2001
From: Fabien Amarger <fabien.amarger@digitanie.org>
Date: Mon, 25 Nov 2024 17:36:33 +0100
Subject: [PATCH 1/3] feat(errors): Add IncorrectlyDefinedParameter error

---
 tdd/errors.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tdd/errors.py b/tdd/errors.py
index 526e3e6..c1b4f16 100644
--- a/tdd/errors.py
+++ b/tdd/errors.py
@@ -205,3 +205,7 @@ def __init__(self, provided_mimetype):
             f"Provided mimetype '{provided_mimetype}' is not supported. Only "
             f"{', '.join(POSSIBLE_MIMETYPES)}, application/json are allowed"
         )
+
+
+class IncorrectlyDefinedParameter(AppException):
+    title = "Incorrectly defined parameter"

From 523740d9263f2f56d84b6f7ec98c8761e5193054 Mon Sep 17 00:00:00 2001
From: Fabien Amarger <fabien.amarger@digitanie.org>
Date: Mon, 25 Nov 2024 17:04:57 +0100
Subject: [PATCH 2/3] fix(route): Handle error on parameter `format` for route
 `/things`

If parameter `format` is not in ['array', 'collection'] returns an
appropriate error message.
---
 tdd/__init__.py | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/tdd/__init__.py b/tdd/__init__.py
index 66ec880..f5240da 100644
--- a/tdd/__init__.py
+++ b/tdd/__init__.py
@@ -34,6 +34,7 @@
     JSONSchemaError,
     IDNotFound,
     WrongMimeType,
+    IncorrectlyDefinedParameter,
 )
 from tdd.td import (
     clear_expired_td,
@@ -109,9 +110,7 @@ def create_app():
     for entry_point in entry_points(group="tdd_api.plugins.blueprints"):
         try:
             app.register_blueprint(entry_point.load())
-            print(
-                f"Imported {entry_point.value} blueprint"
-            )
+            print(f"Imported {entry_point.value} blueprint")
         except Exception as exc:
             print(f"ERROR ({entry_point.name}): {exc}")
             print(
@@ -121,9 +120,7 @@ def create_app():
     for entry_point in entry_points(group="tdd_api.plugins.transformers"):
         try:
             TD_TRANSFORMERS.append(entry_point.load())
-            print(
-                f"Imported {entry_point.value} transformer"
-            )
+            print(f"Imported {entry_point.value} transformer")
         except Exception as exc:
             print(f"ERROR ({entry_point.name}): {exc}")
             print(
@@ -344,6 +341,9 @@ def generate():
                 f' etag="{get_collection_etag()}"'
             )
             return response
+        raise IncorrectlyDefinedParameter(
+            "'format' parameter is not recognized. Must be 'array' or 'collection' if defined."
+        )
 
     @app.route("/things/<id>", methods=["GET"])
     def describe_td(id):

From 51b777601239c80899e1b75522a5eb3ca1cfdebe Mon Sep 17 00:00:00 2001
From: Fabien Amarger <fabien.amarger@digitanie.org>
Date: Mon, 25 Nov 2024 17:13:22 +0100
Subject: [PATCH 3/3] fix(black): Update black formatting after upgrade

---
 tdd/common.py | 17 +++++------------
 tdd/sparql.py |  2 +-
 2 files changed, 6 insertions(+), 13 deletions(-)

diff --git a/tdd/common.py b/tdd/common.py
index c4b6ef5..94a2ca1 100644
--- a/tdd/common.py
+++ b/tdd/common.py
@@ -28,7 +28,6 @@
     query,
 )
 from tdd.metadata import insert_metadata, delete_metadata
-from tdd.errors import IDNotFound
 from tdd.config import CONFIG
 
 
@@ -56,14 +55,11 @@ def json_ld_to_ntriples(ld_content):
     input_data = json.dumps(ld_content) + "\n"
     with resources.path("tdd.lib", "transform-to-nt.js") as transform_lib_path:
         p = subprocess.Popen(
-            [
-                "node",
-                transform_lib_path
-            ],
+            ["node", transform_lib_path],
             stdin=subprocess.PIPE,
             stdout=subprocess.PIPE,
             stderr=subprocess.PIPE,
-            universal_newlines=True
+            universal_newlines=True,
         )
         p.stdin.write(input_data)
         p.stdin.flush()
@@ -111,14 +107,11 @@ def frame_nt_content(nt_content, frame):
     input_data = json.dumps([ntriples, frame]) + "\n"
     with resources.path("tdd.lib", "frame-jsonld.js") as frame_lib_path:
         p = subprocess.Popen(
-            [
-                "node",
-                frame_lib_path
-            ],
+            ["node", frame_lib_path],
             stdin=subprocess.PIPE,
             stdout=subprocess.PIPE,
             stderr=subprocess.PIPE,
-            universal_newlines=True
+            universal_newlines=True,
         )
         p.stdin.write(input_data)
         p.stdin.flush()
@@ -136,6 +129,6 @@ def get_id_description(uri, content_type, ontology):
     if not resp.text.strip() or not (
         re.search(r"^[^\#]", resp.text, re.MULTILINE)
     ):  # because some SPARQL endpoint may send "# Empty file" as response
-        #raise IDNotFound()
+        # raise IDNotFound()
         abort(404)
     return resp.text
diff --git a/tdd/sparql.py b/tdd/sparql.py
index 2945142..934a5e0 100644
--- a/tdd/sparql.py
+++ b/tdd/sparql.py
@@ -212,7 +212,7 @@ def query(
                 sparqlendpoint,
                 data={"update": querystring},
             )
-    
+
     if resp.status_code not in status_codes:
         raise FusekiError(resp)
     return resp