Fix: Issue 43 - Produces wrong signatures #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: a lot of Exception has been added and removed
BREAKING CHANGE: a lot of Exception has been added and removed
This reverts commit 74aeffa.
koptan
force-pushed
the
issue-43-produces-wrong-signatures
branch
from
6475248 to
7a1c0e8
Compare
|
@borisrizov-zf, rebase is done. |
borisrizov-zf
requested changes
Mar 6, 2024
borisrizov-zf
requested changes
Mar 12, 2024
|
@borisrizov-zf it's done, please check ... thanks |
|
@koptan please rebase and we can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #43, by adding the correct header values for JWS based on https://w3c.github.io/vc-jws-2020/#json-web-signature-2020
Pre-review checks
Please ensure to do as many of the following checks as possible, before asking for committer review: