Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageLoadingTable Message Translations #368

Open
Usmanfee opened this issue Oct 30, 2024 · 1 comment
Open

PageLoadingTable Message Translations #368

Usmanfee opened this issue Oct 30, 2024 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@Usmanfee
Copy link
Contributor

Current Behavior

Currently we don't have any way to support messages with translation for PageLoadingTable. Since it is using Table component under the hood to render the Table and Table component supports noRowsMsg prop to display message so in PageLoadingTable component I introduced noRowsMsg prop for Table component to render messages in PageLoadingTable.

Expected Behavior

PageLoadingTable component should display provided message and its translation in EN and DE.

Steps To Reproduce

Technical User Management is one of Page which is using PageLoadingTable component .

  • Login to Portal App.
  • Navigate to the Technical user management.
  • Search for data that doesn't exist (No search data case).
  • View the table when no data is present (Empty Table case).
@Usmanfee Usmanfee added the bug Something isn't working label Oct 30, 2024
@github-project-automation github-project-automation bot moved this to NEW USER REQUEST in Portal Oct 30, 2024
@MaximilianHauer MaximilianHauer moved this from NEW USER REQUEST to BACKLOG in Portal Nov 18, 2024
@MaximilianHauer MaximilianHauer added this to the Release 25.03 milestone Nov 18, 2024
@oyo
Copy link
Contributor

oyo commented Nov 18, 2024

@Usmanfee currently the shared components don't support i18n at all. All texts and messages have to be translated before and passed as props by the calling application. So I guess this means we have to expose the nowRowsMsg in the API.

On the long run it would be nice to have shared components handle translations but if we decide to do that we should implement a solution that works for all components.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: BACKLOG
Development

No branches or pull requests

3 participants