Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Include dependency check before release #1818

Closed
wants to merge 7 commits into from
Closed

feat: Include dependency check before release #1818

wants to merge 7 commits into from

Conversation

bmg13
Copy link
Contributor

@bmg13 bmg13 commented Feb 27, 2025 •
edited
Loading

WHAT

Perform the dependency check before release in main branch instead on all branches in PR targetting main and publish the DEPENDENCIES file to GitHub pages.

WHY

Considering this dependency validation can happen only before release, this is an overhead removed in PRs and additionally provides the dependencies information in GH Pages as well.

FURTHER NOTES

Some reasoning behind the decisions proposed:

  • The creation, validation and publishing of dependencies information is done on three situations: every night, on each new commit in main and by workflow call. This promotes having a valid DEPENDENCIES file, i.e. with no rejected or restricted dependencies, by the time a release is to be done.
  • The preexisting run-dash action in sig-infra is called to promote reusability of this check on other TX repos as well.

Closes #1743

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bmg13 bmg13 marked this pull request as ready for review February 27, 2025 20:55
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 8, 2025

This pull request is stale because it has been open for 7 days with no activity.

@github-actions github-actions bot added the stale label Mar 8, 2025
ndr-brt
ndr-brt requested changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@ndr-brt ndr-brt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is doing too many things, please stick with the plan reported in the issue #1743 . Following the PR title the only changes needed here are the ones to add the check before the release, no publish on gh-pages, no replacement in the NOTICE file.
The process could sound slow but it will permit to have consistent and reasonable contributions instead of a big one that does thing not really needed (e.g. the "schedule" thing).

@bmg13
Copy link
Contributor Author

bmg13 commented Mar 10, 2025 •
edited
Loading

This PR is doing too many things, please stick with the plan reported in the issue #1743 . Following the PR title the only changes needed here are the ones to add the check before the release, no publish on gh-pages, no replacement in the NOTICE file. The process could sound slow but it will permit to have consistent and reasonable contributions instead of a big one that does thing not really needed (e.g. the "schedule" thing).

This makes sense, will break this PR in smaller ones with specific scopes.
Firs PR for checking the dependencies can be found in here: #1831

@bmg13 bmg13 closed this Mar 10, 2025
@bmg13 bmg13 mentioned this pull request Mar 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndr-brt ndr-brt ndr-brt requested changes

@rafaelmag110 rafaelmag110 Awaiting requested review from rafaelmag110 rafaelmag110 is a code owner

Assignees

@bmg13 bmg13

Labels
stale
Projects
EDC PR Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get rid of the dependency check
2 participants
@bmg13 @ndr-brt