Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block contract definitions with empty assetSelector #1773

Closed
2 tasks done
rafaelmag110 opened this issue Jan 30, 2025 · 0 comments · Fixed by #1786
Closed
2 tasks done

Block contract definitions with empty assetSelector #1773

rafaelmag110 opened this issue Jan 30, 2025 · 0 comments · Fixed by #1786
Assignees
Labels
enhancement New feature or request

Comments

@rafaelmag110
Copy link
Contributor

rafaelmag110 commented Jan 30, 2025

WHAT

Tractusx-edc should provide a feature that blocks the creation/update of contract definitions to contain
an empty asset selector.
This feature should have the option to be switched on/off, being off the default state.

WHY

The assetsSelector property is a query (similar to a SQL SELECT statement) that returns a set of assets the
contract definition applies to. When left empty, the default behavior of the connector is to apply the contract
definition to all registered assets.

Unwillingly, mostly due to lack of proper connector usage knowledge, users might expose datasets that shouldn't be
exposed.

STEPS

  • Provide a decision record outline the decision to include such feature and explaining the approach
  • Implement the decided upon approach

FURTHER NOTES

Aligned with eclipse-tractusx/sig-release#927

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
1 participant